Skip to content

Commit 55c01da

Browse files
authored
fix(firefox): fire "requestfailed" event on network errors (#1817)
1 parent f594229 commit 55c01da

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
"main": "index.js",
1010
"playwright": {
1111
"chromium_revision": "759546",
12-
"firefox_revision": "1082",
12+
"firefox_revision": "1083",
1313
"webkit_revision": "1197"
1414
},
1515
"scripts": {

test/network.spec.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -241,10 +241,10 @@ describe('Network Events', function() {
241241
expect(responses[0].request()).toBeTruthy();
242242
});
243243

244-
it.fail(FFOX)('Page.Events.RequestFailed', async({page, server}) => {
244+
it('Page.Events.RequestFailed', async({page, server}) => {
245245
server.setRoute('/one-style.css', (req, res) => {
246-
req.socket.write('deadbeef');
247-
req.socket.end();
246+
res.setHeader('Content-Type', 'text/css');
247+
res.socket.destroy();
248248
});
249249
const failedRequests = [];
250250
page.on('requestfailed', request => failedRequests.push(request));
@@ -254,7 +254,7 @@ describe('Network Events', function() {
254254
expect(await failedRequests[0].response()).toBe(null);
255255
expect(failedRequests[0].resourceType()).toBe('stylesheet');
256256
if (CHROMIUM) {
257-
expect(failedRequests[0].failure().errorText).toBe('net::ERR_INVALID_HTTP_RESPONSE');
257+
expect(failedRequests[0].failure().errorText).toBe('net::ERR_EMPTY_RESPONSE');
258258
} else if (WEBKIT) {
259259
if (MAC)
260260
expect(failedRequests[0].failure().errorText).toBe('The network connection was lost.');
@@ -263,7 +263,7 @@ describe('Network Events', function() {
263263
else
264264
expect(failedRequests[0].failure().errorText).toBe('Message Corrupt');
265265
} else {
266-
expect(failedRequests[0].failure().errorText).toBe('NS_ERROR_FAILURE');
266+
expect(failedRequests[0].failure().errorText).toBe('NS_ERROR_NET_RESET');
267267
}
268268
expect(failedRequests[0].frame()).toBeTruthy();
269269
});

0 commit comments

Comments
 (0)