chore: remove cli (#2976)

It will be a separate package instead.

Author: dgozman

package-lock.json

@@ -8,9 +8,6 @@
   "engines": {
     "node": ">=10.15.0"
   },
-  "bin": {
-    "playwright": "lib/cli/index.js"
-  },
   "scripts": {
     "ctest": "cross-env BROWSER=chromium node --unhandled-rejections=strict test/test.js",
     "ftest": "cross-env BROWSER=firefox node --unhandled-rejections=strict test/test.js",
@@ -42,7 +39,6 @@
   },
   "license": "Apache-2.0",
   "dependencies": {
-    "commander": "^5.1.0",
     "debug": "^4.1.1",
     "extract-zip": "^2.0.0",
     "https-proxy-agent": "^5.0.0",

package.json

@@ -15,7 +15,6 @@
  * limitations under the License.
  */
 
-import { Writable } from 'stream';
 import { isUnderTest, helper, deprecate} from './helper';
 import * as network from './network';
 import { Page, PageBinding } from './page';
@@ -69,7 +68,6 @@ export abstract class BrowserContextBase extends EventEmitter implements Browser
   readonly _downloads = new Set<Download>();
   readonly _browserBase: BrowserBase;
   readonly _apiLogger: Logger;
-  private _debugController: DebugController | undefined;
 
   constructor(browserBase: BrowserBase, options: BrowserContextOptions, isPersistentContext: boolean) {
     super();
@@ -82,16 +80,8 @@ export abstract class BrowserContextBase extends EventEmitter implements Browser
   }
 
   async _initialize() {
-    if (helper.isDebugMode() || helper.isRecordMode()) {
-      this._debugController = new DebugController(this, {
-        recorderOutput: helper.isRecordMode() ? process.stdout : undefined
-      });
-    }
-  }
-
-  _initDebugModeForTest(options: { recorderOutput: Writable }): DebugController {
-    this._debugController = new DebugController(this, options);
-    return this._debugController;
+    if (helper.isDebugMode())
+      new DebugController(this);
   }
 
   async waitForEvent(event: string, optionsOrPredicate: types.WaitForEventOptions = {}): Promise<any> {

src/browserContext.ts

@@ -14,24 +14,15 @@
  * limitations under the License.
  */
 
-import { Writable } from 'stream';
 import { BrowserContextBase } from '../browserContext';
 import { Events } from '../events';
 import * as frames from '../frames';
 import * as js from '../javascript';
 import { Page } from '../page';
-import { RecorderController } from './recorderController';
 import DebugScript from './injected/debugScript';
 
 export class DebugController {
-  private _options: { recorderOutput?: Writable | undefined };
-
-  constructor(context: BrowserContextBase, options: { recorderOutput?: Writable | undefined }) {
-    this._options = options;
-
-    if (options.recorderOutput)
-      new RecorderController(context, options.recorderOutput);
-
+  constructor(context: BrowserContextBase) {
     context.on(Events.BrowserContext.Page, (page: Page) => {
       for (const frame of page.frames())
         this.ensureInstalledInFrame(frame);
@@ -42,13 +33,8 @@ export class DebugController {
   private async ensureInstalledInFrame(frame: frames.Frame): Promise<js.JSHandle<DebugScript> | undefined> {
     try {
       const mainContext = await frame._mainContext();
-      return await mainContext.createDebugScript({ console: true, record: !!this._options.recorderOutput });
+      return await mainContext.createDebugScript({ console: true });
     } catch (e) {
     }
   }
-
-  async ensureInstalledInFrameForTest(frame: frames.Frame): Promise<void> {
-    const handle = await this.ensureInstalledInFrame(frame);
-    await handle!.evaluate(debugScript => debugScript.recorder!.refreshListeners());
-  }
 }

src/cli/index.ts

@@ -15,17 +15,13 @@
  */
 
 import { ConsoleAPI } from './consoleApi';
-import { Recorder } from './recorder';
 import InjectedScript from '../../injected/injectedScript';
 
 export default class DebugScript {
   consoleAPI: ConsoleAPI | undefined;
-  recorder: Recorder | undefined;
 
-  initialize(injectedScript: InjectedScript, options: { console?: boolean, record?: boolean }) {
+  initialize(injectedScript: InjectedScript, options: { console?: boolean }) {
     if (options.console)
       this.consoleAPI = new ConsoleAPI(injectedScript);
-    if (options.record)
-      this.recorder = new Recorder(injectedScript);
   }
 }