Skip to content

Commit 46508c6

Browse files
authored
test: try to unflake one more cookie test (#2381)
1 parent ece4789 commit 46508c6

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

test/defaultbrowsercontext.spec.js

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -300,13 +300,16 @@ describe('launchPersistentContext()', function() {
300300
await removeUserDataDir(userDataDir);
301301
await removeUserDataDir(userDataDir2);
302302
});
303-
it.slow().fail(WIN && CHROMIUM)('should restore cookies from userDataDir', async({browserType, defaultBrowserOptions, server}) => {
304-
// TODO: Flaky! See https://github.com/microsoft/playwright/pull/1795/checks?check_run_id=587685496
303+
it.slow()('should restore cookies from userDataDir', async({browserType, defaultBrowserOptions, server}) => {
305304
const userDataDir = await makeUserDataDir();
306305
const browserContext = await browserType.launchPersistentContext(userDataDir, defaultBrowserOptions);
307306
const page = await browserContext.newPage();
308307
await page.goto(server.EMPTY_PAGE);
309-
await page.evaluate(() => document.cookie = 'doSomethingOnlyOnce=true; expires=Fri, 31 Dec 9999 23:59:59 GMT');
308+
const documentCookie = await page.evaluate(() => {
309+
document.cookie = 'doSomethingOnlyOnce=true; expires=Fri, 31 Dec 9999 23:59:59 GMT';
310+
return document.cookie;
311+
});
312+
expect(documentCookie).toBe('doSomethingOnlyOnce=true');
310313
await browserContext.close();
311314

312315
const browserContext2 = await browserType.launchPersistentContext(userDataDir, defaultBrowserOptions);
@@ -319,7 +322,7 @@ describe('launchPersistentContext()', function() {
319322
const browserContext3 = await browserType.launchPersistentContext(userDataDir2, defaultBrowserOptions);
320323
const page3 = await browserContext3.newPage();
321324
await page3.goto(server.EMPTY_PAGE);
322-
expect(await page3.evaluate(() => localStorage.hey)).not.toBe('doSomethingOnlyOnce=true');
325+
expect(await page3.evaluate(() => document.cookie)).not.toBe('doSomethingOnlyOnce=true');
323326
await browserContext3.close();
324327

325328
// This might throw. See https://github.com/GoogleChrome/puppeteer/issues/2778

0 commit comments

Comments
 (0)