Skip to content

Commit 2926d33

Browse files
authored
test: disable flaky firefox tests (#1912)
1 parent 89007c8 commit 2926d33

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

test/fixtures.spec.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,10 @@ describe('Fixtures', function() {
124124
// TODO: ideally, we would expect the SIGKILL on the browser from
125125
// force kill, but that's racy with sending two signals.
126126
});
127-
it.slow()('should kill the browser on SIGTERM + SIGINT', async state => {
127+
// TODO: flaky!
128+
// - firefox: https://github.com/microsoft/playwright/pull/1911/checks?check_run_id=607148951
129+
// - chromium: https://travis-ci.com/github/microsoft/playwright/builds/161356178
130+
it.slow().fail((FFOX || CHROMIUM) && LINUX)('should kill the browser on SIGTERM + SIGINT', async state => {
128131
const result = await testSignal(state, child => {
129132
process.kill(child.pid, 'SIGTERM');
130133
process.kill(child.pid, 'SIGINT');

test/mouse.spec.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
* limitations under the License.
1616
*/
1717

18-
const {FFOX, CHROMIUM, WEBKIT, MAC} = require('./utils').testOptions(browserType);
18+
const {FFOX, CHROMIUM, WEBKIT, MAC, WIN} = require('./utils').testOptions(browserType);
1919

2020
function dimensions() {
2121
const rect = document.querySelector('textarea').getBoundingClientRect();
@@ -28,7 +28,8 @@ function dimensions() {
2828
}
2929

3030
describe('Mouse', function() {
31-
it('should click the document', async({page, server}) => {
31+
// Occasionally times out on FFOX on Windows: https://github.com/microsoft/playwright/pull/1911/checks?check_run_id=607149016
32+
it.fail(FFOX && WIN)('should click the document', async({page, server}) => {
3233
await page.evaluate(() => {
3334
window.clickPromise = new Promise(resolve => {
3435
document.addEventListener('click', event => {

0 commit comments

Comments
 (0)