Skip to content

Commit 21b1be7

Browse files
authored
docs(selectors): fixed selector register example (#3169)
1 parent 6bc02f8 commit 21b1be7

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

docs/api.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3686,7 +3686,7 @@ const { selectors, firefox } = require('playwright'); // Or 'chromium' or 'webk
36863686

36873687
const browser = await firefox.launch();
36883688
const page = await browser.newPage();
3689-
await page.goto('https://example.com');
3689+
await page.setContent(`<div><button>Click me</button></div>`);
36903690

36913691
// Use the selector prefixed with its name.
36923692
const button = await page.$('tag=button');

test/workers.jest.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -58,13 +58,13 @@ describe('Workers', function() {
5858
});
5959
it('should evaluate', async function({page}) {
6060
const workerCreatedPromise = page.waitForEvent('worker');
61-
page.evaluate(() => new Worker(URL.createObjectURL(new Blob(['console.log(1)'], {type: 'application/javascript'}))));
61+
await page.evaluate(() => new Worker(URL.createObjectURL(new Blob(['console.log(1)'], {type: 'application/javascript'}))));
6262
const worker = await workerCreatedPromise;
6363
expect(await worker.evaluate('1+1')).toBe(2);
6464
});
6565
it('should report errors', async function({page}) {
6666
const errorPromise = new Promise(x => page.on('pageerror', x));
67-
page.evaluate(() => new Worker(URL.createObjectURL(new Blob([`
67+
await page.evaluate(() => new Worker(URL.createObjectURL(new Blob([`
6868
setTimeout(() => {
6969
// Do a console.log just to check that we do not confuse it with an error.
7070
console.log('hey');
@@ -77,7 +77,7 @@ describe('Workers', function() {
7777
it('should clear upon navigation', async function({server, page}) {
7878
await page.goto(server.EMPTY_PAGE);
7979
const workerCreatedPromise = page.waitForEvent('worker');
80-
page.evaluate(() => new Worker(URL.createObjectURL(new Blob(['console.log(1)'], {type: 'application/javascript'}))));
80+
await page.evaluate(() => new Worker(URL.createObjectURL(new Blob(['console.log(1)'], {type: 'application/javascript'}))));
8181
const worker = await workerCreatedPromise;
8282
expect(page.workers().length).toBe(1);
8383
let destroyed = false;
@@ -89,7 +89,7 @@ describe('Workers', function() {
8989
it('should clear upon cross-process navigation', async function({server, page}) {
9090
await page.goto(server.EMPTY_PAGE);
9191
const workerCreatedPromise = page.waitForEvent('worker');
92-
page.evaluate(() => new Worker(URL.createObjectURL(new Blob(['console.log(1)'], {type: 'application/javascript'}))));
92+
await page.evaluate(() => new Worker(URL.createObjectURL(new Blob(['console.log(1)'], {type: 'application/javascript'}))));
9393
const worker = await workerCreatedPromise;
9494
expect(page.workers().length).toBe(1);
9595
let destroyed = false;

utils/generate_types/test/test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ playwright.chromium.launch().then(async browser => {
6363
page.on('console', message => {
6464
console.log(message.text());
6565
});
66-
page.evaluate(() => console.log(5, 'hello', { foo: 'bar' }));
66+
await page.evaluate(() => console.log(5, 'hello', { foo: 'bar' }));
6767

6868
{
6969
const result = await page.evaluate(() => {

0 commit comments

Comments
 (0)