Skip to content

Commit 20e2bac

Browse files
committed
test: fix flaky page event test
1 parent 5323700 commit 20e2bac

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

test/launcher.spec.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -177,12 +177,12 @@ module.exports.describe = function({testRunner, expect, defaultBrowserOptions, p
177177
const remote = await playwright.connect({ wsEndpoint: browserServer.wsEndpoint() });
178178
const context = await remote.newContext();
179179
const page = await context.newPage();
180-
let contextClosed = false;
181180
let pageClosed = false;
182-
context.on('close', e => contextClosed = true);
183181
page.on('close', e => pageClosed = true);
184-
await browserServer.close();
185-
expect(contextClosed).toBeTruthy();
182+
await Promise.all([
183+
new Promise(f => context.on('close', f)),
184+
browserServer.close()
185+
]);
186186
expect(pageClosed).toBeTruthy();
187187
});
188188
});

0 commit comments

Comments
 (0)