Skip to content

Commit 1d21c1e

Browse files
authored
feat(webkit): bump to 1347 (#3955)
1 parent 18809b3 commit 1d21c1e

File tree

3 files changed

+41
-22
lines changed

3 files changed

+41
-22
lines changed

browsers.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
},
1414
{
1515
"name": "webkit",
16-
"revision": "1344",
16+
"revision": "1347",
1717
"download": true
1818
}
1919
]

src/server/webkit/protocol.ts

Lines changed: 37 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -2463,6 +2463,10 @@ export module Protocol {
24632463
*/
24642464
export type setBreakpointForEventListenerParameters = {
24652465
eventListenerId: EventListenerId;
2466+
/**
2467+
* Options to apply to this breakpoint to modify its behavior.
2468+
*/
2469+
options?: Debugger.BreakpointOptions;
24662470
}
24672471
export type setBreakpointForEventListenerReturnValue = {
24682472
}
@@ -2976,6 +2980,10 @@ might return multiple quads for inline nodes.
29762980
* Type of the operation to stop upon.
29772981
*/
29782982
type: DOMBreakpointType;
2983+
/**
2984+
* Options to apply to this breakpoint to modify its behavior.
2985+
*/
2986+
options?: Debugger.BreakpointOptions;
29792987
}
29802988
export type setDOMBreakpointReturnValue = {
29812989
}
@@ -3003,6 +3011,10 @@ might return multiple quads for inline nodes.
30033011
* The name of the specific event to stop on.
30043012
*/
30053013
eventName?: string;
3014+
/**
3015+
* Options to apply to this breakpoint to modify its behavior.
3016+
*/
3017+
options?: Debugger.BreakpointOptions;
30063018
}
30073019
export type setEventBreakpointReturnValue = {
30083020
}
@@ -3030,6 +3042,10 @@ might return multiple quads for inline nodes.
30303042
* Whether the URL string is a regular expression.
30313043
*/
30323044
isRegex?: boolean;
3045+
/**
3046+
* Options to apply to this breakpoint to modify its behavior.
3047+
*/
3048+
options?: Debugger.BreakpointOptions;
30333049
}
30343050
export type setURLBreakpointReturnValue = {
30353051
}
@@ -3041,6 +3057,10 @@ might return multiple quads for inline nodes.
30413057
* Resource URL substring. An empty string will stop pausing on all requests.
30423058
*/
30433059
url: string;
3060+
/**
3061+
* Whether the URL string is a regular expression.
3062+
*/
3063+
isRegex?: boolean;
30443064
}
30453065
export type removeURLBreakpointReturnValue = {
30463066
}
@@ -3760,6 +3780,10 @@ might return multiple quads for inline nodes.
37603780
*/
37613781
export type setPauseOnDebuggerStatementsParameters = {
37623782
enabled: boolean;
3783+
/**
3784+
* Options to apply to this breakpoint to modify its behavior.
3785+
*/
3786+
options?: BreakpointOptions;
37633787
}
37643788
export type setPauseOnDebuggerStatementsReturnValue = {
37653789
}
@@ -3771,6 +3795,10 @@ might return multiple quads for inline nodes.
37713795
* Pause on exceptions mode.
37723796
*/
37733797
state: "none"|"uncaught"|"all";
3798+
/**
3799+
* Options to apply to this breakpoint to modify its behavior.
3800+
*/
3801+
options?: BreakpointOptions;
37743802
}
37753803
export type setPauseOnExceptionsReturnValue = {
37763804
}
@@ -3779,6 +3807,10 @@ might return multiple quads for inline nodes.
37793807
*/
37803808
export type setPauseOnAssertionsParameters = {
37813809
enabled: boolean;
3810+
/**
3811+
* Options to apply to this breakpoint to modify its behavior.
3812+
*/
3813+
options?: BreakpointOptions;
37823814
}
37833815
export type setPauseOnAssertionsReturnValue = {
37843816
}
@@ -3787,6 +3819,10 @@ might return multiple quads for inline nodes.
37873819
*/
37883820
export type setPauseOnMicrotasksParameters = {
37893821
enabled: boolean;
3822+
/**
3823+
* Options to apply to this breakpoint to modify its behavior.
3824+
*/
3825+
options?: BreakpointOptions;
37903826
}
37913827
export type setPauseOnMicrotasksReturnValue = {
37923828
}
@@ -4515,15 +4551,6 @@ Left=1, Right=2, Middle=4, Back=8, Forward=16, None=0.
45154551
object: Runtime.RemoteObject;
45164552
hints: { [key: string]: string };
45174553
}
4518-
/**
4519-
* Fired when the backend has alternate domains that need to be activated.
4520-
*/
4521-
export type activateExtraDomainsPayload = {
4522-
/**
4523-
* Domain names that need activation
4524-
*/
4525-
domains: string[];
4526-
}
45274554

45284555
/**
45294556
* Enables inspector domain notifications.
@@ -6436,10 +6463,7 @@ Left=1, Right=2, Middle=4, Back=8, Forward=16, None=0.
64366463
* Forces the given appearance for the page.
64376464
*/
64386465
export type setForcedAppearanceParameters = {
6439-
/**
6440-
* Appearance name to force. Empty string disables the override.
6441-
*/
6442-
appearance: Appearance;
6466+
appearance?: Appearance;
64436467
}
64446468
export type setForcedAppearanceReturnValue = {
64456469
}
@@ -8359,7 +8383,6 @@ Left=1, Right=2, Middle=4, Back=8, Forward=16, None=0.
83598383
"Heap.trackingComplete": Heap.trackingCompletePayload;
83608384
"Inspector.evaluateForTestInFrontend": Inspector.evaluateForTestInFrontendPayload;
83618385
"Inspector.inspect": Inspector.inspectPayload;
8362-
"Inspector.activateExtraDomains": Inspector.activateExtraDomainsPayload;
83638386
"LayerTree.layerTreeDidChange": LayerTree.layerTreeDidChangePayload;
83648387
"Memory.memoryPressure": Memory.memoryPressurePayload;
83658388
"Memory.trackingStart": Memory.trackingStartPayload;

test/dispatchevent.spec.ts

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17-
import { it, expect, options } from './playwright.fixtures';
17+
import { it, expect } from './playwright.fixtures';
1818

1919
it('should dispatch click event', async ({page, server}) => {
2020
await page.goto(server.PREFIX + '/input/button.html');
@@ -125,9 +125,7 @@ it('should be atomic', async ({playwright, page}) => {
125125
expect(await page.evaluate(() => window['_clicked'])).toBe(true);
126126
});
127127

128-
it('should dispatch drag drop events', (test, parameters) => {
129-
test.fail(options.WEBKIT(parameters));
130-
}, async ({page, server}) => {
128+
it('should dispatch drag drop events', async ({page, server}) => {
131129
await page.goto(server.PREFIX + '/drag-n-drop.html');
132130
const dataTransfer = await page.evaluateHandle(() => new DataTransfer());
133131
await page.dispatchEvent('#source', 'dragstart', { dataTransfer });
@@ -139,9 +137,7 @@ it('should dispatch drag drop events', (test, parameters) => {
139137
}, {source, target})).toBeTruthy();
140138
});
141139

142-
it('should dispatch drag drop events', (test, parameters) => {
143-
test.fail(options.WEBKIT(parameters));
144-
}, async ({page, server}) => {
140+
it('should dispatch drag drop events', async ({page, server}) => {
145141
await page.goto(server.PREFIX + '/drag-n-drop.html');
146142
const dataTransfer = await page.evaluateHandle(() => new DataTransfer());
147143
const source = await page.$('#source');

0 commit comments

Comments
 (0)