fix: make launch options in ffPlaywright optional (#637)

abreu-dev · aslushnikov · commit 199d094c6d2e · 2020-01-24T13:27:49.000-08:00
diff --git a/src/server/ffPlaywright.ts b/src/server/ffPlaywright.ts
@@ -63,7 +63,7 @@ export class FFPlaywright implements Playwright {
     this._revision = preferredRevision;
   }
 
-  async launch(options: LaunchOptions): Promise<FFBrowser> {
+  async launch(options?: LaunchOptions): Promise<FFBrowser> {
     const app = await this.launchBrowserApp(options);
     const browser = await FFBrowser.connect(app.connectOptions());
     // Hack: for typical launch scenario, ensure that close waits for actual process termination.

Original file line number	Diff line number	Diff line change
`@@ -63,7 +63,7 @@ export class FFPlaywright implements Playwright {`
`63`	`63`	`this._revision = preferredRevision;`
`64`	`64`	`}`
`65`	`65`
`66`		`- async launch(options: LaunchOptions): Promise<FFBrowser> {`
	`66`	`+ async launch(options?: LaunchOptions): Promise<FFBrowser> {`
`67`	`67`	`const app = await this.launchBrowserApp(options);`
`68`	`68`	`const browser = await FFBrowser.connect(app.connectOptions());`
`69`	`69`	`// Hack: for typical launch scenario, ensure that close waits for actual process termination.`