Skip to content

Commit 15668f0

Browse files
authored
chore: make WebKit @ MacOS 10.14 error more prominent (#6943)
The new message is much more prominent in the logs: ``` aslushnikov:~/prog/playwright(make-deprecation-error-more-prominent)$ node a.js node:internal/process/promises:246 triggerUncaughtException(err, true /* fromPromise */); ^ browserType.launch: Protocol error (Playwright.enable): Browser closed. ==================== Browser output: ==================== <launching> /Users/aslushnikov/prog/playwright/browser_patches/deprecated-webkit-mac-10.14/pw_run.sh --inspector-pipe --headless --no-startup-window <launched> pid=5120 [pid=5120][out] **************************************************************** [pid=5120][out] **************************************************************** [pid=5120][out] [pid=5120][out] ERROR: MacOS version is too old! [pid=5120][out] [pid=5120][out] This version of Playwright does not support running [pid=5120][out] WebKit on MacOS 10.14. Please either: [pid=5120][out] - update your operating system to version 10.15 or higher [pid=5120][out] - use Playwright v1.11 or older [pid=5120][out] [pid=5120][out] **************************************************************** [pid=5120][out] **************************************************************** [pid=5120] <process did exit: exitCode=1, signal=null> [pid=5120] starting temporary directories cleanup ```
1 parent d0eaec3 commit 15668f0

File tree

2 files changed

+16
-3
lines changed

2 files changed

+16
-3
lines changed
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
1445
2-
Changed: [email protected] Thu Jun 3 15:24:06 PDT 2021
1+
1446
2+
Changed: [email protected] Mon Jun 7 14:01:01 PDT 2021
Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,17 @@
11
#!/bin/bash
22

3-
echo "ERROR: this version of Playwright does not support running WebKit on MacOS 10.14. Please either update MacOS to 10.15+ or use [email protected]"
3+
cat << EndOfMessage
4+
****************************************************************
5+
****************************************************************
6+
7+
ERROR: MacOS version is too old!
8+
9+
This version of Playwright does not support running
10+
WebKit on MacOS 10.14. Please either:
11+
- update your operating system to version 10.15 or higher
12+
- use Playwright v1.11 or older
13+
14+
****************************************************************
15+
****************************************************************
16+
EndOfMessage
417
exit 1;

0 commit comments

Comments
 (0)