Skip to content

Commit 0db09f8

Browse files
authored
test: roll test runner to 0.9.20 (#4062)
1 parent 2df6425 commit 0db09f8

21 files changed

+481
-517
lines changed

package-lock.json

Lines changed: 77 additions & 89 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,8 +50,8 @@
5050
"ws": "^7.3.1"
5151
},
5252
"devDependencies": {
53-
"@playwright/test": "^0.9.7",
54-
"@playwright/test-runner": "^0.9.17",
53+
"@playwright/test": "0.9.9",
54+
"@playwright/test-runner": "0.9.20",
5555
"@types/debug": "^4.1.5",
5656
"@types/extract-zip": "^1.6.2",
5757
"@types/mime": "^2.0.3",

test/browsertype-connect.spec.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -234,9 +234,11 @@ describe('connect', (suite, { wire }) => {
234234
await page.close();
235235
});
236236

237-
it('should save videos from remote browser', async ({browserType, remoteServer, testOutputPath}) => {
237+
it('should save videos from remote browser', (test, {browserName, platform}) => {
238+
test.flaky(browserName === 'firefox' && platform === 'win32');
239+
}, async ({browserType, remoteServer, testInfo}) => {
238240
const remote = await browserType.connect({ wsEndpoint: remoteServer.wsEndpoint() });
239-
const videosPath = testOutputPath();
241+
const videosPath = testInfo.outputPath();
240242
const context = await remote.newContext({
241243
videosPath,
242244
videoSize: { width: 320, height: 240 },

test/channels.spec.ts

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -23,15 +23,16 @@ type DomainFixtures = {
2323
domain: any;
2424
};
2525

26-
const fixtures = baseFixtures.declareWorkerFixtures<DomainFixtures>();
27-
fixtures.defineWorkerFixture('domain', async ({ }, test) => {
28-
const local = domain.create();
29-
local.run(() => { });
30-
let err;
31-
local.on('error', e => err = e);
32-
await test(null);
33-
if (err)
34-
throw err;
26+
const fixtures = baseFixtures.defineWorkerFixtures<DomainFixtures>({
27+
domain: async ({ }, test) => {
28+
const local = domain.create();
29+
local.run(() => { });
30+
let err;
31+
local.on('error', e => err = e);
32+
await test(null);
33+
if (err)
34+
throw err;
35+
}
3536
});
3637

3738
const { it, expect } = fixtures;

0 commit comments

Comments
 (0)