Skip to content

Commit 0d16b16

Browse files
authored
fix(firefox): unskip worker error test (#2805)
1 parent e12e245 commit 0d16b16

File tree

2 files changed

+9
-4
lines changed

2 files changed

+9
-4
lines changed

browsers.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
},
88
{
99
"name": "firefox",
10-
"revision": "1117"
10+
"revision": "1118"
1111
},
1212
{
1313
"name": "webkit",

test/workers.spec.js

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -62,10 +62,15 @@ describe('Workers', function() {
6262
const worker = await workerCreatedPromise;
6363
expect(await worker.evaluate('1+1')).toBe(2);
6464
});
65-
it.fail(FFOX)('should report errors', async function({page}) {
66-
// Times out after the 4/15/2020 roll.
65+
it('should report errors', async function({page}) {
6766
const errorPromise = new Promise(x => page.on('pageerror', x));
68-
page.evaluate(() => new Worker(URL.createObjectURL(new Blob([`setTimeout(() => { throw new Error('this is my error'); })`], {type: 'application/javascript'}))));
67+
page.evaluate(() => new Worker(URL.createObjectURL(new Blob([`
68+
setTimeout(() => {
69+
// Do a console.log just to check that we do not confuse it with an error.
70+
console.log('hey');
71+
throw new Error('this is my error');
72+
})
73+
`], {type: 'application/javascript'}))));
6974
const errorLog = await errorPromise;
7075
expect(errorLog.message).toContain('this is my error');
7176
});

0 commit comments

Comments
 (0)