Skip to content

Commit 04ed683

Browse files
authored
tests(firefox): unskip network idle tests (#1832)
1 parent e67603d commit 04ed683

File tree

1 file changed

+2
-6
lines changed

1 file changed

+2
-6
lines changed

test/navigation.spec.js

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -557,19 +557,15 @@ describe('Page.goto', function() {
557557
return page.setContent(`<script src='networkidle.js'></script>`, { waitUntil: 'networkidle2' });
558558
}, true);
559559
});
560-
it.fail(FFOX)('should wait for networkidle0 in setContent with request from previous navigation', async({page, server}) => {
561-
// TODO: in Firefox window.stop() does not cancel outstanding requests, and we also lack 'init' lifecycle,
562-
// therefore we don't clear inflight requests at the right time.
560+
it('should wait for networkidle0 in setContent with request from previous navigation', async({page, server}) => {
563561
await page.goto(server.EMPTY_PAGE);
564562
server.setRoute('/foo.js', () => {});
565563
await page.setContent(`<script>fetch('foo.js');</script>`);
566564
await networkIdleTest(page.mainFrame(), server, 'networkidle0', () => {
567565
return page.setContent(`<script src='networkidle.js'></script>`, { waitUntil: 'networkidle0' });
568566
}, true);
569567
});
570-
it.fail(FFOX)('should wait for networkidle2 in setContent with request from previous navigation', async({page, server}) => {
571-
// TODO: in Firefox window.stop() does not cancel outstanding requests, and we also lack 'init' lifecycle,
572-
// therefore we don't clear inflight requests at the right time.
568+
it('should wait for networkidle2 in setContent with request from previous navigation', async({page, server}) => {
573569
await page.goto(server.EMPTY_PAGE);
574570
server.setRoute('/foo.js', () => {});
575571
await page.setContent(`<script>fetch('foo.js');</script>`);

0 commit comments

Comments
 (0)