Skip to content
This repository was archived by the owner on Dec 7, 2021. It is now read-only.

Commit 44f9e4b

Browse files
authored
fix: Updates backwards compat & fixes cntk export image bug (#789)
Fixes an issue where the images exported out of a video file were missing file extension for video projects.
1 parent c38daca commit 44f9e4b

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

src/providers/export/cntk.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,13 +76,12 @@ export class CntkExportProvider extends ExportProvider<ICntkExportProviderOption
7676
});
7777
});
7878

79+
const buffer = await HtmlFileReader.getAssetArray(assetMetadata.asset);
7980
const folderName = exportSplit === ExportSplit.Train ? "positive" : "testImages";
8081
const labelsPath = `${this.exportFolderName}/${folderName}/${assetMetadata.asset.name}.bboxes.labels.tsv`;
8182
const boundingBoxPath = `${this.exportFolderName}/${folderName}/${assetMetadata.asset.name}.bboxes.tsv`;
8283
const binaryPath = `${this.exportFolderName}/${folderName}/${assetMetadata.asset.name}`;
8384

84-
const buffer = await HtmlFileReader.getAssetArray(assetMetadata.asset);
85-
8685
await Promise.all([
8786
this.storageProvider.writeText(labelsPath, labelData.join(os.EOL)),
8887
this.storageProvider.writeText(boundingBoxPath, boundingBoxData.join(os.EOL)),

src/services/projectService.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,9 @@ export default class ProjectService implements IProjectService {
171171
* @param project The project to update
172172
*/
173173
private ensureBackwardsCompatibility(project: IProject) {
174-
if (project.version === "2.0.0") {
174+
const projectVersion = project.version.toLowerCase();
175+
176+
if (projectVersion.startsWith("2.0.0")) {
175177
// Required for backwards compatibility with v2.0.0 release
176178
if (project.exportFormat.providerType === "tensorFlowPascalVOC") {
177179
project.exportFormat.providerType = "pascalVOC";

0 commit comments

Comments
 (0)