From a5d2ef4b2f4508db59644e38ce19e1b424c49d4b Mon Sep 17 00:00:00 2001 From: Darius Dzien Date: Sun, 24 Apr 2022 08:45:36 -0500 Subject: [PATCH 1/2] Add Node v18 to CI --- .github/workflows/accept-baselines-fix-lints.yaml | 2 +- .github/workflows/ci.yml | 6 +++--- .github/workflows/new-release-branch.yaml | 2 +- .github/workflows/nightly.yaml | 2 +- .github/workflows/release-branch-artifact.yaml | 2 +- .github/workflows/rich-navigation.yml | 2 +- .github/workflows/set-version.yaml | 2 +- .github/workflows/sync-branch.yaml | 2 +- .github/workflows/twoslash-repros.yaml | 4 ++-- .github/workflows/update-lkg.yml | 2 +- .github/workflows/update-package-lock.yaml | 2 +- 11 files changed, 14 insertions(+), 14 deletions(-) diff --git a/.github/workflows/accept-baselines-fix-lints.yaml b/.github/workflows/accept-baselines-fix-lints.yaml index 640ed67e8c738..2662646cc05fe 100644 --- a/.github/workflows/accept-baselines-fix-lints.yaml +++ b/.github/workflows/accept-baselines-fix-lints.yaml @@ -10,7 +10,7 @@ jobs: steps: - uses: actions/checkout@v2 - name: Use node version 14 - uses: actions/setup-node@v1 + uses: actions/setup-node@v3 with: node-version: 14 registry-url: https://registry.npmjs.org/ diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 370575013cb10..f598d5479470d 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -16,14 +16,14 @@ jobs: strategy: matrix: - node-version: [14.x, 16.x, 17.x] + node-version: [14.x, 16.x, 17.x, 18.x] steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 with: fetch-depth: 5 - name: Use node version ${{ matrix.node-version }} - uses: actions/setup-node@v1 + uses: actions/setup-node@v3 with: node-version: ${{ matrix.node-version }} - name: Remove existing TypeScript diff --git a/.github/workflows/new-release-branch.yaml b/.github/workflows/new-release-branch.yaml index 65c36525f38ed..90b8bbdf5efdb 100644 --- a/.github/workflows/new-release-branch.yaml +++ b/.github/workflows/new-release-branch.yaml @@ -10,7 +10,7 @@ jobs: steps: - name: Use node version 14.x - uses: actions/setup-node@v1 + uses: actions/setup-node@v3 with: node-version: 14.x - uses: actions/checkout@v2 diff --git a/.github/workflows/nightly.yaml b/.github/workflows/nightly.yaml index c207c19ace2c4..bbcf21cbc257a 100644 --- a/.github/workflows/nightly.yaml +++ b/.github/workflows/nightly.yaml @@ -15,7 +15,7 @@ jobs: steps: - uses: actions/checkout@v2 - name: Use node version 14 - uses: actions/setup-node@v1 + uses: actions/setup-node@v3 with: node-version: 14 registry-url: https://registry.npmjs.org/ diff --git a/.github/workflows/release-branch-artifact.yaml b/.github/workflows/release-branch-artifact.yaml index 388f6415af699..17bb3be4680d6 100644 --- a/.github/workflows/release-branch-artifact.yaml +++ b/.github/workflows/release-branch-artifact.yaml @@ -12,7 +12,7 @@ jobs: steps: - uses: actions/checkout@v2 - name: Use node version 14 - uses: actions/setup-node@v1 + uses: actions/setup-node@v3 with: node-version: 14 - name: Remove existing TypeScript diff --git a/.github/workflows/rich-navigation.yml b/.github/workflows/rich-navigation.yml index 4097f2893c3a2..82ba9bf54f1df 100644 --- a/.github/workflows/rich-navigation.yml +++ b/.github/workflows/rich-navigation.yml @@ -19,7 +19,7 @@ jobs: with: fetch-depth: 5 - - uses: actions/setup-node@v2 + - uses: actions/setup-node@v3 with: node-version: 14 diff --git a/.github/workflows/set-version.yaml b/.github/workflows/set-version.yaml index a3077e39e2db7..5b1338daff2aa 100644 --- a/.github/workflows/set-version.yaml +++ b/.github/workflows/set-version.yaml @@ -10,7 +10,7 @@ jobs: steps: - name: Use node version 14.x - uses: actions/setup-node@v1 + uses: actions/setup-node@v3 with: node-version: 14.x - uses: actions/checkout@v2 diff --git a/.github/workflows/sync-branch.yaml b/.github/workflows/sync-branch.yaml index a26718e606376..fae67017c617b 100644 --- a/.github/workflows/sync-branch.yaml +++ b/.github/workflows/sync-branch.yaml @@ -15,7 +15,7 @@ jobs: steps: - name: Use node version 14.x - uses: actions/setup-node@v1 + uses: actions/setup-node@v3 with: node-version: 14.x - uses: actions/checkout@v2 diff --git a/.github/workflows/twoslash-repros.yaml b/.github/workflows/twoslash-repros.yaml index 0a8ba026ac412..e0be654305aa1 100644 --- a/.github/workflows/twoslash-repros.yaml +++ b/.github/workflows/twoslash-repros.yaml @@ -24,7 +24,7 @@ jobs: runs-on: ubuntu-latest steps: - name: Use node - uses: actions/setup-node@v1 + uses: actions/setup-node@v3 - uses: microsoft/TypeScript-Twoslash-Repro-Action@master with: github-token: ${{ secrets.TS_BOT_GITHUB_TOKEN }} @@ -36,7 +36,7 @@ jobs: - uses: actions/checkout@v3 with: fetch-depth: 0 - - uses: actions/setup-node@v1 + - uses: actions/setup-node@v3 with: node-version: 16 - uses: microsoft/TypeScript-Twoslash-Repro-Action@master diff --git a/.github/workflows/update-lkg.yml b/.github/workflows/update-lkg.yml index 4faf242f8bfaa..cac9c6c4c0665 100644 --- a/.github/workflows/update-lkg.yml +++ b/.github/workflows/update-lkg.yml @@ -10,7 +10,7 @@ jobs: steps: - uses: actions/checkout@v2 - name: Use node version 14 - uses: actions/setup-node@v1 + uses: actions/setup-node@v3 with: node-version: 14 registry-url: https://registry.npmjs.org/ diff --git a/.github/workflows/update-package-lock.yaml b/.github/workflows/update-package-lock.yaml index 3880b5cae83ce..fcb6d8960c48c 100644 --- a/.github/workflows/update-package-lock.yaml +++ b/.github/workflows/update-package-lock.yaml @@ -13,7 +13,7 @@ jobs: steps: - uses: actions/checkout@v2 - - uses: actions/setup-node@v1 + - uses: actions/setup-node@v3 with: node-version: 14 registry-url: https://registry.npmjs.org/ From 7e61f0747bafbd5b95d3c10a4b544cd4f7ac0764 Mon Sep 17 00:00:00 2001 From: Darius Dzien Date: Tue, 26 Apr 2022 17:36:28 -0500 Subject: [PATCH 2/2] Address comments --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index f598d5479470d..b95b0481ed251 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -16,7 +16,7 @@ jobs: strategy: matrix: - node-version: [14.x, 16.x, 17.x, 18.x] + node-version: [14.x, 16.x, 18.x] steps: - uses: actions/checkout@v3