Dup tags arg html (#186)

* Improves rethrow exceptions from throw e; to just throw; to avoid loss of stack data info and removes unused lines of code for cleanliness identified by LGTM/Semmle. Fixes loss of confidence data in some cases from serialization where not specified. Fixes one hardcoded output filename for tagtest and prevents msg for console winding up in log.

* Fix #183

Author: guyacosta

AppInspector.CLI/html/resources/js/appinspector.js

@@ -153,10 +153,12 @@ class TemplateInsertion {
             if (match.ruleId === ruleid || match.ruleName === ruleid) {
                 let $li = $('<li>');
                 let $a = $('<a>');
+                let $l = match.startLocationLine-3;
+                if ($l < 0) $l = 1; //fix #183
                 $a.addClass('content-link')
                     .attr('href', '#')
                     .data('excerpt', excerpt)
-                    .data('startLocationLine', match.startLocationLine - 3)
+                    .data('startLocationLine', $l)
                     .text(removePrefix(match.fileName));
                 $li.append($a);
                 $('#file_listing_modal ul').append($li);

AppInspector/Commands/AnalyzeCommand.cs

@@ -166,6 +166,9 @@ void ConfigFileOutput()
                 if (!string.IsNullOrEmpty(_arg_outputFile))
                     WriteOnce.Info("output file ignored for html format");
                 _outputWriter.TextWriter = Console.Out;
+
+                if (!_arg_outputUniqueTagsOnly) //fix #183
+                    throw new Exception(ErrMsg.GetString(ErrMsg.ID.ANALYZE_NODUPLICATES_HTML_FORMAT));
             }
             else if (!string.IsNullOrEmpty(_arg_outputFile))
             {

AppInspector/ErrorMessage.cs

@@ -29,6 +29,7 @@ public enum ID
             ANALYZE_FILE_TYPE_OPEN,
             ANALYZE_OUTPUT_FILE,
             ANALYZE_REPORTSIZE_WARN,
+            ANALYZE_NODUPLICATES_HTML_FORMAT,
             CMD_PREPARING_REPORT,
             CMD_COMPLETED,
             CMD_CRITICAL_FILE_ERR,

AppInspector/Properties/Resources.Designer.cs

@@ -144,6 +144,9 @@
   <data name="ANALYZE_LANGUAGE_NOTFOUND" xml:space="preserve">
     <value>File skipped: Language not found for file {0}</value>
   </data>
+  <data name="ANALYZE_NODUPLICATES_HTML_FORMAT" xml:space="preserve">
+    <value>Allow duplicate matches argument not supported for html output format.  Select a different output format (text/json) or remove the argument.</value>
+  </data>
   <data name="ANALYZE_NOPATTERNS" xml:space="preserve">
     <value>No pattern matches were detected for files in source path</value>
   </data>