Fix for identifying zip file processing and html GUI tag matching the same rule. (#156)

guyacosta · web-flow · commit d7edba04df2a · 2020-03-05T22:04:48.000-08:00
diff --git a/AppInspector.CLI/Properties/launchSettings.json b/AppInspector.CLI/Properties/launchSettings.json
@@ -1,8 +1,7 @@
 {
   "profiles": {
     "AppInspector.CLI": {
-      "commandName": "Project",
-      "commandLineArgs": "analyze -s c:\\temp\\main.cpp"
+      "commandName": "Project"
     }
   }
 }
diff --git a/AppInspector.CLI/preferences/tagreportgroups.json b/AppInspector.CLI/preferences/tagreportgroups.json
@@ -375,7 +375,7 @@
             "detectedIcon": "fas fa-play-circle"
           },
           {
-            "searchPattern": "Data.Compressed",
+            "searchPattern": "Data.Zipfile",
             "displayName": "Zip file processing",
             "detectedIcon": "far fa-file-archive"
           },
diff --git a/AppInspector/rules/default/data_handling/compressed_files.json b/AppInspector/rules/default/data_handling/compressed_files.json
@@ -9,15 +9,7 @@
     "severity": "moderate",
     "patterns": [
       {
-        "pattern": "\\.(zip|gz|gzip|gem|tar|tgz|tar.gz|xz|7z)",
-        "type": "regex",
-        "scopes": [ "code", "comment" ],
-        "modifiers": [ "i" ],
-        "confidence": "high",
-        "_comment": ""
-      },
-      {
-        "pattern": "zip|gz|gzip|gem|tar|tgz|tar\\.gz|xz|7z",
+        "pattern": "\\.(zip|gz|gzip|gem|tar|tgz|tar\\.gz|xz|7z)",
         "type": "regex-word",
         "scopes": [ "code", "comment" ],
         "modifiers": [ "i" ],

Original file line number	Diff line number	Diff line change
`@@ -1,8 +1,7 @@`
`1`	`1`	`{`
`2`	`2`	`"profiles": {`
`3`	`3`	`"AppInspector.CLI": {`
`4`		`- "commandName": "Project",`
`5`		`- "commandLineArgs": "analyze -s c:\\temp\\main.cpp"`
	`4`	`+ "commandName": "Project"`
`6`	`5`	`}`
`7`	`6`	`}`
`8`	`7`	`}`
Original file line number	Diff line number	Diff line change
`@@ -375,7 +375,7 @@`
`375`	`375`	`"detectedIcon": "fas fa-play-circle"`
`376`	`376`	`},`
`377`	`377`	`{`
`378`		`- "searchPattern": "Data.Compressed",`
	`378`	`+ "searchPattern": "Data.Zipfile",`
`379`	`379`	`"displayName": "Zip file processing",`
`380`	`380`	`"detectedIcon": "far fa-file-archive"`
`381`	`381`	`},`