Fixes #146, #147

Author: Guy Acosta

AppInspector/Commands/AnalyzeCommand.cs

@@ -25,11 +25,12 @@ public class AnalyzeCommand : ICommand
 
         public enum ExitCode
         {
-            NoMatches = 0,
-            MatchesFound = 1,
+            Success = 0,
+            NoMatches = 1,
             CriticalError = 2
         }
 
+
         IEnumerable<string> _srcfileList;
         AppProfile _appProfile;
         RuleProcessor _rulesProcessor;
@@ -267,11 +268,21 @@ public int Run()
             // Iterate through all files and process against rules
             foreach (string filename in _srcfileList)
             {
-                ArchiveFileType archiveFileType = MiniMagic.DetectFileType(filename);
+                ArchiveFileType archiveFileType;
+                try //fix for #146
+                {
+                    archiveFileType = MiniMagic.DetectFileType(filename);
+                }
+                catch (Exception e)
+                {
+                    throw new OpException(ErrMsg.FormatString(ErrMsg.ID.ANALYZE_FILE_TYPE_OPEN, filename));
+                }
+
                 if (archiveFileType == ArchiveFileType.UNKNOWN)//not a known zipped file type
                     ProcessAsFile(filename);
                 else
-                    UnZipAndProcess(filename,archiveFileType);
+                    UnZipAndProcess(filename, archiveFileType);
+                
             }
 
             WriteOnce.General("\r"+ErrMsg.FormatString(ErrMsg.ID.ANALYZE_FILES_PROCESSED_PCNT, 100));
@@ -298,7 +309,7 @@ public int Run()
             }
 
             return _appProfile.MatchList.Count() == 0 ? (int)ExitCode.NoMatches :
-                (int)ExitCode.MatchesFound;
+                (int)ExitCode.Success;
         }
 
 

AppInspector/ErrorMessage.cs

@@ -26,6 +26,7 @@ public enum ID
             ANALYZE_COMPRESSED_FILESIZE_WARN,
             ANALYZE_COMPRESSED_PROCESSING,
             ANALYZE_COMPRESSED_ERROR,
+            ANALYZE_FILE_TYPE_OPEN,
             ANALYZE_OUTPUT_FILE,
             ANALYZE_REPORTSIZE_WARN,
             CMD_PREPARING_REPORT,

AppInspector/Properties/Resources.Designer.cs

@@ -138,6 +138,9 @@
   <data name="ANALYZE_FILES_PROCESSED_PCNT" xml:space="preserve">
     <value>{0}% source files processed</value>
   </data>
+  <data name="ANALYZE_FILE_TYPE_OPEN" xml:space="preserve">
+    <value>Unable to determine file type.  File open error for {0}</value>
+  </data>
   <data name="ANALYZE_LANGUAGE_NOTFOUND" xml:space="preserve">
     <value>File skipped: Language not found for file {0}</value>
   </data>

AppInspector/Properties/Resources.resx

@@ -1,8 +1,7 @@
 {
   "profiles": {
     "ApplicationInspector": {
-      "commandName": "Project",
-      "commandLineArgs": "analyze -s c:\\temp\\main.cpp -b"
+      "commandName": "Project"
     }
   }
 }