Skip to content
This repository was archived by the owner on Aug 30, 2021. It is now read-only.

Commit 3cc8caf

Browse files
committed
Fixing Header Active items
1 parent 6455bdc commit 3cc8caf

File tree

4 files changed

+6
-5
lines changed

4 files changed

+6
-5
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,12 +51,12 @@
5151
"grunt-contrib-watch": "~0.6.1",
5252
"grunt-contrib-jshint": "~0.10.0",
5353
"grunt-contrib-csslint": "^0.2.0",
54+
"grunt-ngmin": "0.0.3",
5455
"grunt-contrib-uglify": "~0.4.0",
5556
"grunt-contrib-cssmin": "~0.9.0",
5657
"grunt-nodemon": "~0.2.1",
5758
"grunt-concurrent": "~0.5.0",
5859
"grunt-mocha-test": "~0.10.0",
59-
"grunt-ngmin": "0.0.3",
6060
"grunt-karma": "~0.8.2",
6161
"load-grunt-tasks": "~0.4.0",
6262
"karma": "~0.12.0",

public/modules/articles/config/articles.client.config.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
angular.module('articles').run(['Menus',
55
function(Menus) {
66
// Set top bar menu items
7-
Menus.addMenuItem('topbar', 'Articles', 'articles', 'dropdown');
7+
Menus.addMenuItem('topbar', 'Articles', 'articles', 'dropdown', '/articles(/create)?');
88
Menus.addSubMenuItem('topbar', 'articles', 'List Articles', 'articles');
99
Menus.addSubMenuItem('topbar', 'articles', 'New Article', 'articles/create');
1010
}

public/modules/core/services/menus.client.service.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,15 +74,16 @@ angular.module('core').service('Menus', [
7474
};
7575

7676
// Add menu item object
77-
this.addMenuItem = function(menuId, menuItemTitle, menuItemURL, menuClass, menuItemUIRoute, isPublic, roles) {
77+
this.addMenuItem = function(menuId, menuItemTitle, menuItemURL, menuItemType, menuItemUIRoute, isPublic, roles) {
7878
// Validate that the menu exists
7979
this.validateMenuExistance(menuId);
8080

8181
// Push new menu item
8282
this.menus[menuId].items.push({
8383
title: menuItemTitle,
8484
link: menuItemURL,
85-
menuClass: menuClass || '',
85+
menuItemType: menuItemType || 'item',
86+
menuItemClass: menuItemType,
8687
uiRoute: menuItemUIRoute || ('/' + menuItemURL),
8788
isPublic: isPublic || this.menus[menuId].isPublic,
8889
roles: roles || this.defaultRoles,

public/modules/core/views/header.client.view.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
</div>
1111
<nav class="collapse navbar-collapse" collapse="!isCollapsed" role="navigation">
1212
<ul class="nav navbar-nav" data-ng-if="menu.shouldRender(authentication.user);">
13-
<li data-ng-repeat="item in menu.items" data-ng-if="item.shouldRender(authentication.user);" ng-switch="item.menuClass" class="{{item.menuClass}}" ui-route="{{item.uiRoute}}" ng-class="{active: $uiRoute}">
13+
<li data-ng-repeat="item in menu.items" data-ng-if="item.shouldRender(authentication.user);" ng-switch="item.menuItemType" ui-route="{{item.uiRoute}}" ng-class="{active: ($uiRoute), '{{item.menuItemClass}}': item.menuItemClass}">
1414
<a ng-switch-when="dropdown" href="#" class="dropdown-toggle" data-toggle="dropdown">
1515
<span data-ng-bind="item.title"></span>
1616
<b class="caret"></b>

0 commit comments

Comments
 (0)