feat: add skip validate flag

Author: mcarvin8

README.md

@@ -31,15 +31,15 @@ Example `.apextestsgitdeltarc` file:
 Example commit messages:
 
 ```
-fix: update triggers Apex::AccountTriggerHandlerTest OpportunityTriggerHandlerTest::Apex  
-chore: add sandbox setup Apex::PrepareMySandboxTest::Apex  
-fix: resolve quoting issues Apex::QuoteControllerTest::Apex  
+fix: update triggers Apex::AccountTriggerHandlerTest OpportunityTriggerHandlerTest::Apex
+chore: add sandbox setup Apex::PrepareMySandboxTest::Apex
+fix: resolve quoting issues Apex::QuoteControllerTest::Apex
 ```
 
 Test classes can be separated by commas, spaces, or both. The final output is a space-separated, alphabetically sorted list:
 
 ```
-AccountTriggerHandlerTest OpportunityTriggerHandlerTest PrepareMySandboxTest QuoteControllerTest  
+AccountTriggerHandlerTest OpportunityTriggerHandlerTest PrepareMySandboxTest QuoteControllerTest
 ```
 
 These tests can then be used with the `RunSpecifiedTests` flag of the Salesforce CLI deploy command:
@@ -48,9 +48,7 @@ These tests can then be used with the `RunSpecifiedTests` flag of the Salesforce
 sf project deploy start -x package/package.xml -l RunSpecifiedTests -t $(sf atgd delta --from "HEAD~1" --to "HEAD")
 ```
 
-> Note:
->	- Only test classes found in package directories (as listed in `sfdx-project.json` in the `--to` commit) will be included.
->	- If no matching test classes are found, the output is empty, and a warning is printed, but the command does not fail.
+> Note: - Only test classes found in package directories (as listed in `sfdx-project.json` in the `--to` commit) will be included. - If no matching test classes are found, the output is empty, and a warning is printed, but the command does not fail.
 
 ## Why This Plugin
 
@@ -72,13 +70,14 @@ sf plugins install [email protected]
 
 ```
 USAGE
-  $ sf atgd delta -f <value> -t <value> [--json]
+  $ sf atgd delta -f <value> -t <value> -v [--json]
 
 FLAGS
-  -f, --from=<value>  Commit SHA from where the commit message log is done. 
-                      This SHA's commit message will not be included in the results.
-  -t, --to=<value>    Commit SHA to where the commit message log is done.
-                      [default: HEAD]
+  -f, --from=<value>          Commit SHA from where the commit message log is done.
+                              This SHA's commit message will not be included in the results.
+  -t, --to=<value>            Commit SHA to where the commit message log is done.
+                              [default: HEAD]
+  -v, --skip-test-validation  Skip validating that tests exist in the local package directories.
 
 GLOBAL FLAGS
   --json  Format output as json.
@@ -87,7 +86,13 @@ DESCRIPTION
   Parse commit messages over a range and return the Apex tests to deploy against.
 
 EXAMPLES
+  Get tests from the most recent commit, confirming they exist in the local package directories.
+
     $ sf atgd delta --from "HEAD~1" --to "HEAD"
+
+  Get tests from the most recent commit, skipping the local package directory validation.
+
+    $ sf atgd delta --from "HEAD~1" --to "HEAD" -v
 ```
 
 ## Alternative

messages/delta.md

@@ -17,3 +17,7 @@ Commit SHA from where the commit message log is done. This SHA's commit message
 # flags.to.summary
 
 Commit SHA to where the commit message log is done.
+
+# flags.skip-test-validation.summary
+
+Skip validating that tests exist in the local package directories.

src/commands/atgd/delta.ts

@@ -29,14 +29,21 @@ export default class ApexTestDelta extends SfCommand<TestDeltaResult> {
       summary: messages.getMessage('flags.from.summary'),
       required: true,
     }),
+    'skip-test-validation': Flags.boolean({
+      char: 'v',
+      summary: messages.getMessage('flags.skip-test-validation.summary'),
+      required: true,
+      default: false,
+    }),
   };
 
   public async run(): Promise<TestDeltaResult> {
     const { flags } = await this.parse(ApexTestDelta);
     const toGitRef = flags['to'];
     const fromGitRef = flags['from'];
+    const validate = flags['skip-test-validation'];
 
-    const result = await extractTestClasses(fromGitRef, toGitRef);
+    const result = await extractTestClasses(fromGitRef, toGitRef, validate);
     const tests = result.validatedClasses;
     const warnings = result.warnings;
     if (warnings.length > 0) {

src/service/extractTestClasses.ts

@@ -5,7 +5,8 @@ import { validateClassPaths } from './validateClassPaths.js';
 
 export async function extractTestClasses(
   fromRef: string,
-  toRef: string
+  toRef: string,
+  skipValidate: boolean
 ): Promise<{ validatedClasses: string; warnings: string[] }> {
   const testClasses: Set<string> = new Set();
   const { repoRoot, matchedMessages } = await retrieveCommitMessages(fromRef, toRef);
@@ -23,13 +24,18 @@ export async function extractTestClasses(
     });
   });
 
-  const unvalidatedClasses: string[] = Array.from(testClasses);
-  let validatedClasses: string = '';
+  let sortedClasses: string[] = Array.from(testClasses).sort((a, b) => a.localeCompare(b));
+
+  if (skipValidate) {
+    return { validatedClasses: sortedClasses.join(' '), warnings: [] };
+  }
+
   const result =
-    unvalidatedClasses.length > 0
-      ? await validateClassPaths(unvalidatedClasses, toRef, repoRoot)
+    sortedClasses.length > 0
+      ? await validateClassPaths(sortedClasses, toRef, repoRoot)
       : { validatedClasses: new Set(), warnings: [] };
-  let sortedClasses: string[] = [];
+
+  let validatedClasses: string = '';
   if (result.validatedClasses.size > 0) {
     sortedClasses = Array.from(result.validatedClasses) as string[];
     sortedClasses = sortedClasses.sort((a, b) => a.localeCompare(b));

test/commands/delta/delta.test.ts

@@ -48,7 +48,7 @@ describe('atgd unit test', () => {
     await rm(tempDir, { recursive: true });
   });
 
-  it('log the commits using relative refs and return the delta test class string without any warnings.', async () => {
+  it('return tests without any warnings.', async () => {
     await ApexTestDelta.run(['--from', 'HEAD~2', '--to', 'HEAD']);
     const output = sfCommandStubs.log
       .getCalls()
@@ -61,4 +61,36 @@ describe('atgd unit test', () => {
       .join('\n');
     expect(warnings).to.include('');
   });
+  it('return no tests without warnings.', async () => {
+    await createTemporaryCommit('chore: add some tests', 'packaged/classes/TestClass4.cls', 'dummy 2');
+    await ApexTestDelta.run(['--from', 'HEAD~1']);
+    const output = sfCommandStubs.log
+      .getCalls()
+      .flatMap((c) => c.args)
+      .join('\n');
+    expect(output).to.include('');
+    const warnings = sfCommandStubs.warn
+      .getCalls()
+      .flatMap((c) => c.args)
+      .join('\n');
+    expect(warnings).to.include('');
+  });
+  it('return no test with warnings.', async () => {
+    await createTemporaryCommit('chore: adding new tests Apex::TestClass33::Apex', 'TestClass4.cls', 'dummy 2');
+    await ApexTestDelta.run(['--from', 'HEAD~1']);
+    const logOutput = sfCommandStubs.log
+      .getCalls()
+      .flatMap((c) => c.args)
+      .join('\n');
+    expect(logOutput).to.include('');
+  });
+  it('skip validation and return tests without warnings', async () => {
+    await createTemporaryCommit('chore: adding new tests Apex::TestClass33::Apex', 'TestClass4.cls', 'dummy 2');
+    await ApexTestDelta.run(['--from', 'HEAD~1', '--skip-test-validation']);
+    const logOutput = sfCommandStubs.log
+      .getCalls()
+      .flatMap((c) => c.args)
+      .join('\n');
+    expect(logOutput).to.include('TestClass33');
+  });
 });