test: run all formats in 1 command (#197)

Author: mcarvin8

test/commands/acc-transformer/transform.nut.ts

@@ -1,7 +1,5 @@
-/* eslint-disable no-await-in-loop */
 'use strict';
 
-import { resolve } from 'node:path';
 import { describe, it, expect } from '@jest/globals';
 
 import { execCmd, TestSession } from '@salesforce/cli-plugins-testkit';
@@ -14,6 +12,7 @@ import { preTestSetup } from '../../utils/testSetup.js';
 
 describe('acc-transformer transform NUTs', () => {
   let session: TestSession;
+  const formatString = formatOptions.map((f) => `--format ${f}`).join(' ');
 
   beforeAll(async () => {
     session = await TestSession.create({ devhubAuthStrategy: 'NONE' });
@@ -25,16 +24,21 @@ describe('acc-transformer transform NUTs', () => {
     await postTestCleanup();
   });
 
-  formatOptions.forEach((format) => {
-    inputJsons.forEach(({ label, path }) => {
-      const reportExtension = getExtensionForFormat(format);
-      const reportPath = resolve(`${format}_${label}${reportExtension}`);
-      it(`transforms the ${label} command JSON file into ${format} format`, async () => {
-        const command = `acc-transformer transform --coverage-json "${path}" --output-report "${reportPath}" --format ${format} -i "samples"`;
-        const output = execCmd(command, { ensureExitCode: 0 }).shellOutput.stdout;
-
-        expect(output.replace('\n', '')).toStrictEqual(`The coverage report has been written to: ${reportPath}`);
-      });
+  inputJsons.forEach(({ label, path }) => {
+    it(`transforms the ${label} command JSON file into all formats`, async () => {
+      const command = `acc-transformer transform --coverage-json "${path}" --output-report "${label}.xml" ${formatString} -i "samples"`;
+      const output = execCmd(command, { ensureExitCode: 0 }).shellOutput.stdout;
+
+      const expectedOutput =
+        'The coverage report has been written to: ' +
+        formatOptions
+          .map((f) => {
+            const ext = getExtensionForFormat(f);
+            return `${label}-${f}${ext}`;
+          })
+          .join(', ');
+
+      expect(output.replace('\n', '')).toStrictEqual(expectedOutput);
     });
   });
 

test/commands/acc-transformer/transform.test.ts

@@ -1,7 +1,4 @@
-/* eslint-disable no-await-in-loop */
 'use strict';
-import { resolve } from 'node:path';
-import { rm } from 'node:fs/promises';
 import { describe, it, expect } from '@jest/globals';
 
 import { TestContext } from '@salesforce/core/testSetup';
@@ -25,17 +22,11 @@ describe('acc-transformer transform unit tests', () => {
 
   afterAll(async () => {
     await postTestCleanup();
-    await rm('coverage-cobertura.xml');
-    await rm('coverage-sonar.xml');
   });
 
-  formatOptions.forEach((format) => {
-    inputJsons.forEach(({ label, path }) => {
-      const reportExtension = format === 'lcovonly' ? 'info' : 'xml';
-      const reportPath = resolve(`${format}_${label}.${reportExtension}`);
-      it(`transforms the ${label} command JSON file into ${format} format`, async () => {
-        await transformCoverageReport(path, reportPath, [format], ['samples']);
-      });
+  inputJsons.forEach(({ label, path }) => {
+    it(`transforms the ${label} command JSON file into all output formats`, async () => {
+      await transformCoverageReport(path, `${label}.xml`, formatOptions, ['samples']);
     });
   });
   it('confirm the reports created are the same as the baselines.', async () => {
@@ -78,7 +69,4 @@ describe('acc-transformer transform unit tests', () => {
   it('create a jacoco report using only 1 package directory', async () => {
     await transformCoverageReport(deployCoverage, 'coverage.xml', ['jacoco'], ['packaged', 'force-app']);
   });
-  it('create 2 reports at once', async () => {
-    await transformCoverageReport(deployCoverage, 'coverage.xml', ['sonar', 'cobertura'], ['samples']);
-  });
 });

test/utils/baselineCompare.ts

@@ -31,7 +31,7 @@ export async function compareToBaselines(): Promise<void> {
   for (const format of formatOptions as Array<keyof typeof baselineMap>) {
     for (const { label } of inputJsons) {
       const reportExtension = getExtensionForFormat(format);
-      const outputPath = resolve(`${format}_${label}${reportExtension}`);
+      const outputPath = resolve(`${label}-${format}${reportExtension}`);
       const outputContent = await readFile(outputPath, 'utf-8');
       const baselineContent = await readFile(baselineMap[format], 'utf-8');
 

test/utils/testCleanup.ts

@@ -17,7 +17,7 @@ export async function postTestCleanup(): Promise<void> {
     .flatMap((format) =>
       inputJsons.map(({ label }) => {
         const reportExtension = getExtensionForFormat(format);
-        return resolve(`${format}_${label}${reportExtension}`);
+        return resolve(`${label}-${format}${reportExtension}`);
       })
     )
     .concat(defaultPath);