fix: move code from command into function (#184)

Author: mcarvin8

src/commands/acc-transformer/transform.ts

@@ -10,11 +10,11 @@ Messages.importMessagesDirectoryFromMetaUrl(import.meta.url);
 const messages = Messages.loadMessages('apex-code-coverage-transformer', 'transformer.transform');
 
 export default class TransformerTransform extends SfCommand<TransformerTransformResult> {
-  public static readonly summary = messages.getMessage('summary');
-  public static readonly description = messages.getMessage('description');
-  public static readonly examples = messages.getMessages('examples');
+  public static override readonly summary = messages.getMessage('summary');
+  public static override readonly description = messages.getMessage('description');
+  public static override readonly examples = messages.getMessages('examples');
 
-  public static readonly flags = {
+  public static override readonly flags = {
     'coverage-json': Flags.file({
       summary: messages.getMessage('flags.coverage-json.summary'),
       char: 'j',
@@ -44,32 +44,24 @@ export default class TransformerTransform extends SfCommand<TransformerTransform
 
   public async run(): Promise<TransformerTransformResult> {
     const { flags } = await this.parse(TransformerTransform);
-    const jsonFilePath = flags['coverage-json'];
-    const outputReportPath = flags['output-report'];
-    const ignoreDirs = flags['ignore-package-directory'] ?? [];
-    const format = flags['format'];
-    let finalPath = outputReportPath;
-
     const warnings: string[] = [];
 
-    try {
-      const result = await transformCoverageReport(jsonFilePath, outputReportPath, format, ignoreDirs);
-      warnings.push(...result.warnings);
-      finalPath = result.finalPath;
-    } catch (err) {
-      this.error(
-        'The provided JSON does not match a known coverage data format from the Salesforce deploy or test command.'
-      );
-    }
+    const result = await transformCoverageReport(
+      flags['coverage-json'],
+      flags['output-report'],
+      flags['format'],
+      flags['ignore-package-directory'] ?? []
+    );
+    warnings.push(...result.warnings);
+    const finalPath = result.finalPath;
 
-    // Print warnings if any
     if (warnings.length > 0) {
       warnings.forEach((warning) => {
         this.warn(warning);
       });
     }
 
     this.log(`The coverage report has been written to ${finalPath}`);
-    return { path: outputReportPath };
+    return { path: finalPath };
   }
 }

src/transformers/coverageTransformer.ts

@@ -72,7 +72,9 @@ export async function transformCoverageReport(
       filesProcessed++;
     });
   } else {
-    throw new Error('Unknown coverage data type. Cannot generate report.');
+    throw new Error(
+      'The provided JSON does not match a known coverage data format from the Salesforce deploy or test command.'
+    );
   }
 
   if (filesProcessed === 0) {

test/commands/acc-transformer/transform.nut.ts

@@ -43,7 +43,7 @@ describe('acc-transformer transform NUTs', () => {
 
   it('confirms a failure on an invalid JSON file.', async () => {
     const command = `acc-transformer transform --coverage-json "${invalidJson}"`;
-    const error = execCmd(command, { ensureExitCode: 2 }).shellOutput.stderr;
+    const error = execCmd(command, { ensureExitCode: 1 }).shellOutput.stderr;
 
     expect(error.replace('\n', '')).to.contain(
       'The provided JSON does not match a known coverage data format from the Salesforce deploy or test command.'