Skip to content

Commit 5fac4fd

Browse files
drchenleticiarossi
authored andcommitted
[Catalog] Fix chip icon colors
It doesn't make sense to use pure black/white for the star icon's unchecked/checked states. Changes to use ?attr/colorControlNormal to support light/dark mode switching and chip icon tinting. PiperOrigin-RevId: 416369553
1 parent e7bc947 commit 5fac4fd

File tree

4 files changed

+5
-3
lines changed

4 files changed

+5
-3
lines changed

catalog/java/io/material/catalog/assets/res/drawable/ic_star_border_black_24.xml renamed to catalog/java/io/material/catalog/assets/res/drawable/ic_star_border_vd_theme_24.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,6 @@
2020
android:viewportWidth="24.0"
2121
android:viewportHeight="24.0">
2222
<path
23-
android:fillColor="#FF000000"
23+
android:fillColor="?attr/colorControlNormal"
2424
android:pathData="M22,9.24l-7.19,-0.62L12,2 9.19,8.63 2,9.24l5.46,4.73L5.82,21 12,17.27 18.18,21l-1.63,-7.03L22,9.24zM12,15.4l-3.76,2.27 1,-4.28 -3.32,-2.88 4.38,-0.38L12,6.1l1.71,4.04 4.38,0.38 -3.32,2.88 1,4.28L12,15.4z"/>
2525
</vector>

catalog/java/io/material/catalog/assets/res/drawable/ic_star_checkable_24.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,5 +17,5 @@
1717
<selector xmlns:android="http://schemas.android.com/apk/res/android">
1818
<item android:state_checked="true"
1919
android:drawable="@drawable/ic_star_vd_theme_24"/>
20-
<item android:drawable="@drawable/ic_star_border_black_24"/>
20+
<item android:drawable="@drawable/ic_star_border_vd_theme_24"/>
2121
</selector>

catalog/java/io/material/catalog/assets/res/drawable/ic_star_vd_theme_24.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,6 @@
1717
android:viewportWidth="24.0"
1818
android:width="24dp">
1919
<path
20-
android:fillColor="@android:color/white"
20+
android:fillColor="?attr/colorControlNormal"
2121
android:pathData="M12,17.27L18.18,21l-1.64,-7.03L22,9.24l-7.19,-0.61L12,2 9.19,8.63 2,9.24l5.46,4.73L5.82,21z"/>
2222
</vector>

catalog/java/io/material/catalog/chip/res/layout/cat_chip_content.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@
5050
android:layout_toRightOf="@id/cat_chip_input"
5151
android:ellipsize="end"
5252
android:text="@string/cat_chip_text"
53+
app:checkedIconVisible="false"
5354
app:chipIcon="@drawable/ic_star_checkable_24"
5455
app:ensureMinTouchTargetSize="true"/>
5556

@@ -83,6 +84,7 @@
8384
android:layout_toRightOf="@id/cat_chip_input_icon"
8485
android:ellipsize="end"
8586
android:text="@string/cat_chip_text"
87+
app:checkedIconVisible="false"
8688
app:chipIcon="@drawable/ic_star_checkable_24"
8789
app:ensureMinTouchTargetSize="true"/>
8890

0 commit comments

Comments
 (0)