Skip to content

Commit 3cf0647

Browse files
drchendsn5ft
authored andcommitted
[Slider] Fix lint error caused by hidden super interface
Overriding the inherited methods from a hidden super interface to fix lint errors caused by those methods being hidden. Resolves #2493 PiperOrigin-RevId: 421909180
1 parent 6c41f07 commit 3cf0647

File tree

2 files changed

+22
-4
lines changed

2 files changed

+22
-4
lines changed

lib/java/com/google/android/material/slider/RangeSlider.java

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -82,10 +82,19 @@ public RangeSlider(@NonNull Context context, @Nullable AttributeSet attrs, int d
8282
*
8383
* To check all the current values, use {@see RangeSlider#getValues()}.
8484
*/
85-
public interface OnChangeListener extends BaseOnChangeListener<RangeSlider> {}
85+
public interface OnChangeListener extends BaseOnChangeListener<RangeSlider> {
86+
@Override
87+
void onValueChange(@NonNull RangeSlider slider, float value, boolean fromUser);
88+
}
8689

8790
/** Interface definition for a callback invoked when a slider's value is changed. */
88-
public interface OnSliderTouchListener extends BaseOnSliderTouchListener<RangeSlider> {}
91+
public interface OnSliderTouchListener extends BaseOnSliderTouchListener<RangeSlider> {
92+
@Override
93+
void onStartTrackingTouch(@NonNull RangeSlider slider);
94+
95+
@Override
96+
void onStopTrackingTouch(@NonNull RangeSlider slider);
97+
}
8998

9099
/**
91100
* {@inheritDoc}

lib/java/com/google/android/material/slider/Slider.java

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,13 +40,22 @@
4040
public class Slider extends BaseSlider<Slider, OnChangeListener, OnSliderTouchListener> {
4141

4242
/** Interface definition for a callback invoked when a slider's value is changed. */
43-
public interface OnChangeListener extends BaseOnChangeListener<Slider> {}
43+
public interface OnChangeListener extends BaseOnChangeListener<Slider> {
44+
@Override
45+
void onValueChange(@NonNull Slider slider, float value, boolean fromUser);
46+
}
4447

4548
/**
4649
* Interface definition for callbacks invoked when a slider's touch event is being
4750
* started/stopped.
4851
*/
49-
public interface OnSliderTouchListener extends BaseOnSliderTouchListener<Slider> {}
52+
public interface OnSliderTouchListener extends BaseOnSliderTouchListener<Slider> {
53+
@Override
54+
void onStartTrackingTouch(@NonNull Slider slider);
55+
56+
@Override
57+
void onStopTrackingTouch(@NonNull Slider slider);
58+
}
5059

5160
public Slider(@NonNull Context context) {
5261
this(context, null);

0 commit comments

Comments
 (0)