Skip to content

Commit 16edbb9

Browse files
pubiqqleticiarossi
authored andcommitted
[MaterialTimePicker] Fix text and cursor alignment on the clock display
Resolves #2834 Resolves #2832 GIT_ORIGIN_REV_ID=dbd966e3fbf8161aaea9389b14adc178bbbe7aad Co-authored-by: paulfthomas PiperOrigin-RevId: 468005512
1 parent 4e323fa commit 16edbb9

File tree

7 files changed

+17
-38
lines changed

7 files changed

+17
-38
lines changed

lib/java/com/google/android/material/timepicker/res/drawable-v21/material_cursor_drawable.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@
1717

1818
<shape xmlns:android="http://schemas.android.com/apk/res/android">
1919
<padding
20-
android:bottom="@dimen/material_cursor_inset_bottom"
21-
android:top="@dimen/material_cursor_inset_top" />
20+
android:bottom="@dimen/material_cursor_inset"
21+
android:top="@dimen/material_cursor_inset" />
2222
<size android:width="@dimen/material_cursor_width" />
2323
<solid android:color="?attr/colorPrimary" />
2424
</shape>

lib/java/com/google/android/material/timepicker/res/drawable/material_cursor_drawable.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@
1717

1818
<shape xmlns:android="http://schemas.android.com/apk/res/android">
1919
<padding
20-
android:bottom="@dimen/material_cursor_inset_bottom"
21-
android:top="@dimen/material_cursor_inset_top" />
20+
android:bottom="@dimen/material_cursor_inset"
21+
android:top="@dimen/material_cursor_inset" />
2222
<size android:width="@dimen/material_cursor_width" />
2323
<solid android:color="@android:color/black" />
2424
</shape>

lib/java/com/google/android/material/timepicker/res/layout/material_time_chip.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,6 @@
1616
-->
1717
<com.google.android.material.chip.Chip
1818
xmlns:android="http://schemas.android.com/apk/res/android"
19-
android:layout_width="96dp"
20-
android:layout_height="80dp"
19+
android:layout_width="@dimen/material_clock_display_width"
20+
android:layout_height="@dimen/material_clock_display_height"
2121
style="?attr/chipStyle" />

lib/java/com/google/android/material/timepicker/res/layout/material_time_input.xml

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,13 +20,12 @@
2020
android:layout_width="wrap_content"
2121
android:layout_height="wrap_content"
2222
app:errorIconDrawable="@null"
23-
app:hintEnabled="false" >
23+
app:hintEnabled="false">
2424

2525
<com.google.android.material.textfield.TextInputEditText
26-
android:layout_width="96dp"
27-
android:textCursorDrawable="@drawable/material_cursor_drawable"
28-
android:layout_height="80dp"
29-
android:paddingBottom="@dimen/material_time_input_padding_bottom" />
26+
android:layout_width="@dimen/material_clock_display_width"
27+
android:layout_height="@dimen/material_clock_display_height"
28+
android:textCursorDrawable="@drawable/material_cursor_drawable" />
3029

3130
<TextView
3231
android:id="@+id/material_label"

lib/java/com/google/android/material/timepicker/res/values-v31/dimens.xml

Lines changed: 0 additions & 21 deletions
This file was deleted.

lib/java/com/google/android/material/timepicker/res/values/dimens.xml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@
1616
-->
1717

1818
<resources>
19+
<dimen name="material_clock_display_width">96dp</dimen>
20+
<dimen name="material_clock_display_height">80dp</dimen>
1921
<dimen name="material_clock_display_padding">24dp</dimen>
2022
<dimen name="material_clock_period_toggle_height">96dp</dimen>
2123
<dimen name="material_clock_period_toggle_width">52dp</dimen>
@@ -30,13 +32,10 @@
3032
<dimen name="material_clock_number_text_size">15sp</dimen>
3133

3234
<!-- cursor dimens -->
33-
<dimen name="material_cursor_inset_bottom">-6dp</dimen>
34-
<dimen name="material_cursor_inset_top">-12dp</dimen>
35+
<dimen name="material_cursor_inset">-4dp</dimen>
3536
<dimen name="material_cursor_width">2dp</dimen>
3637

3738
<dimen name="material_clock_size">256dp</dimen>
38-
<!-- TextInputEditText doesn't properly center pre-S, so add padding fix -->
39-
<dimen name="material_time_input_padding_bottom">6dp</dimen>
4039

4140
<dimen name="material_time_picker_minimum_screen_height">560dp</dimen>
4241
<dimen name="material_time_picker_minimum_screen_width">340dp</dimen>

lib/java/com/google/android/material/timepicker/res/values/styles.xml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@
8484
<style name="Widget.MaterialComponents.TimePicker.Display.TextInputEditText" parent="Widget.MaterialComponents.TextInputEditText.OutlinedBox">
8585
<item name="android:textAppearance">?attr/textAppearanceHeadline3</item>
8686
<item name="android:textSize" tools:ignore="SpUsage">56dp</item>
87-
<item name="android:paddingTop">4dp</item>
87+
<item name="android:paddingTop">0dp</item>
8888
<item name="android:paddingBottom">0dp</item>
8989
<item name="android:inputType">number</item>
9090
<item name="android:maxLength">2</item>
@@ -93,6 +93,7 @@
9393
<item name="android:gravity">center</item>
9494
<item name="android:paddingStart">0dp</item>
9595
<item name="android:paddingEnd">0dp</item>
96+
<item name="android:includeFontPadding">false</item>
9697
</style>
9798

9899
<style name="Widget.MaterialComponents.TimePicker.Display.HelperText" parent="Widget.MaterialComponents.TextView">
@@ -177,7 +178,7 @@
177178
<style name="Widget.Material3.MaterialTimePicker.Display.TextInputEditText" parent="Widget.Material3.TextInputEditText.OutlinedBox">
178179
<item name="android:textAppearance">?attr/textAppearanceHeadlineMedium</item>
179180
<item name="android:textSize" tools:ignore="SpUsage">56dp</item>
180-
<item name="android:paddingTop">4dp</item>
181+
<item name="android:paddingTop">0dp</item>
181182
<item name="android:paddingBottom">0dp</item>
182183
<item name="android:inputType">number</item>
183184
<item name="android:maxLength">2</item>
@@ -186,6 +187,7 @@
186187
<item name="android:gravity">center</item>
187188
<item name="android:paddingStart">0dp</item>
188189
<item name="android:paddingEnd">0dp</item>
190+
<item name="android:includeFontPadding">false</item>
189191
</style>
190192

191193
<style name="Widget.Material3.MaterialTimePicker.Display.HelperText" parent="Widget.MaterialComponents.TimePicker.Display.HelperText">

0 commit comments

Comments
 (0)