Inconsistency with lancer-data README documentation and implementation in lancer-data?

[sealtrowitz]

I apologize if this is the wrong spot for this, but I wasn't sure where else to ask -- I've been helping my friend build an LCP for his homebrew and noticed a bit of an inconsistency with the lancer-data README documentation and actual implementation of said feature in lancer-data itself. Specifically, under the Deployables header, it mentions that:

"A recall value will generate a recall action, removing the deployable from the user's Deployables list and refunding the system the cost value in charges. deactivation does the same as recall but does not refund the charge cost."

...But then checking the Hydra's Tempest Drone and Assassin Drones, both of which are non-Limited deployable systems, they use recall as opposed to deactivation in lancer-data. I went through and checked the rest of the non-Limited deployables in lancer-data I could think of (Lotus Projector, Hive Drone, Sentinel Drone, Tempest Drone, Assassin Drone, and Pattern-A Jericho Deployable Cover is the complete list I looked at; I did not look at Perimeter Command Plate since it explicitly cannot be recalled except through being destroyed or deploying a new one) and they all also use recall.

Is this something I should report on the lancer-data repo, either in regards to the README documentation or those items? Or am I just misunderstanding what cost is (I thought it specifically was an item's Limited cost)? Or am I maybe being unnecessarily pedantic with something that doesn't appear to actually be causing problems?

[jarena3]

I'm not sure I 100% follow -- these systems aren't correctly generating deactivation actions, they're instead generating erroneous recall actions? Is that correct?

[sealtrowitz]

Sorry, I'm probably not explaining it very well. I guess the core of it is, what's the difference between deactivation and recall for deployables? My understanding of the documentation is that recall refunds the cost value, but deactivation does not, so I thought that would mean deactivation should be used for non-limited deployable systems, but that isn't the case in the core data.

[jarena3]

ah, then yes your understanding is correct and that is a bug -- recall should refund limited usage and deactivation should not. Would you mind creating a ticket for this in lancer-data. It may also require changes in compcon (but I will address that seperately)

thanks for running this down!

[sealtrowitz]

I can do that, yeah! I've been busy the past week so I haven't had the chance to yet, but I will do that when I'm able!

[sealtrowitz]

Alright, finally was able to get that submitted at massif-press/lancer-data#192 , sorry for the delay!

[jarena3]

don't worry about it at all! thank you!