Skip to content

Commit a6d13b9

Browse files
committed
http2: addtl http/2 settings
Currently, node.js http/2 is limited in sending SETTINGs, that are currently implemented by nghttp2. However, nghttp2 has the ability to send arbitary SETTINGs, that are not known beforehand. This patch adds this feature including a fall back mechanism, if a SETTING is implemented in a later nghttp2 or node version. Fixes: nodejs#1337
1 parent e1ea8fe commit a6d13b9

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

lib/internal/http2/core.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -946,7 +946,7 @@ function pingCallback(cb) {
946946
// All settings are optional and may be left undefined
947947
const validateSettings = hideStackFrames((settings) => {
948948
if (settings === undefined) return;
949-
assertIsObject(settings.customSettings, 'customSettings', 'Number');
949+
assertIsObject.withoutStackTrace(settings.customSettings, 'customSettings', 'Number');
950950
assertWithinRange.withoutStackTrace('headerTableSize',
951951
settings.headerTableSize,
952952
0, kMaxInt);

0 commit comments

Comments
 (0)