fix: fix tests

Author: marco-ippolito

doc/api/test.md

@@ -609,10 +609,6 @@ added:
   - REPLACEME
 -->
 
-```bash
-node --test-bail
-```
-
 The `--test-bail` flag provides a way to stop the test execution
 as soon as a test fails.
 By enabling this flag, the test runner will exit the test suite early

lib/internal/test_runner/reporter/tap.js

@@ -14,6 +14,7 @@ const {
 const { inspectWithNoCustomRetry } = require('internal/errors');
 const { isError, kEmptyObject } = require('internal/util');
 const { getCoverageReport } = require('internal/test_runner/utils');
+const { kBailedOut } = require('internal/test_runner/test');
 const kDefaultIndent = '    '; // 4 spaces
 const kFrameStartRegExp = /^ {4}at /;
 const kLineBreakRegExp = /\n|\r\n/;

lib/internal/test_runner/test.js

@@ -981,6 +981,7 @@ module.exports = {
   kSubtestsFailed,
   kTestCodeFailure,
   kTestTimeoutFailure,
+  kBailedOut,
   kAborted,
   kUnwrapErrors,
   Suite,

src/node_options.cc

@@ -567,9 +567,6 @@ EnvironmentOptionsParser::EnvironmentOptionsParser() {
             "profile generated with --heap-prof. (default: 512 * 1024)",
             &EnvironmentOptions::heap_prof_interval);
 #endif  // HAVE_INSPECTOR
-  AddOption("--test-bail",
-            "stop test execution when a test has failed",
-            &EnvironmentOptions::test_bail);
   AddOption("--max-http-header-size",
             "set the maximum size of HTTP headers (default: 16384 (16KB))",
             &EnvironmentOptions::max_http_header_size,
@@ -603,6 +600,9 @@ EnvironmentOptionsParser::EnvironmentOptionsParser() {
             "run test at specific shard",
             &EnvironmentOptions::test_shard,
             kAllowedInEnvvar);
+  AddOption("--test-bail",
+            "stop test runner execution on the first test failure",
+            &EnvironmentOptions::test_bail);
   AddOption("--test-udp-no-try-send", "",  // For testing only.
             &EnvironmentOptions::test_udp_no_try_send);
   AddOption("--throw-deprecation",

test/fixtures/test-runner/bail/bail.js

@@ -1,3 +1,4 @@
+'use strict';
 const test = require('node:test');
 
 test('nested', (t) => {

test/fixtures/test-runner/bail/error.js

@@ -1,12 +1,12 @@
-const assert = require('assert');
+'use strict';
 const common = require('../../../common');
-
+const assert = require('assert');
 const test = require('node:test');
 
 test('keep error', (t) => {
-    assert.strictEqual(0, 1);
+  assert.strictEqual(0, 1);
 });
 
-test('dont show', common.mustNotCall( t => {
-    assert.strictEqual(0, 2);
+test('dont show', common.mustNotCall((t) => {
+  assert.strictEqual(0, 2);
 }));

test/parallel/test-runner-bail.js

@@ -13,7 +13,7 @@ const errorTestFile = fixtures.path('test-runner/bail/error.js');
 tmpdir.refresh();
 
 describe('maintain errors', () => {
-  it('should exit at assertion failure', () => {
+  it('should exit on first failure', () => {
     const child = spawnSync(process.execPath, ['--test', '--test-bail', errorTestFile]);
     assert.strictEqual(child.stderr.toString(), '');
     assert.match(child.stdout.toString(), /failureType: 'testCodeFailure'/);
@@ -35,20 +35,6 @@ describe('node:test bail tap', () => {
     assert.doesNotMatch(child.stdout.toString(), /# Subtest: top level/);
     assert.doesNotMatch(child.stdout.toString(), /ok 1 - ok forth/);
     assert.doesNotMatch(child.stdout.toString(), /not ok 2 - fifth/);
-
-  });
-
-  it('should exit not exit if bail isnt set', () => {
-    const child = spawnSync(process.execPath, ['--test', testFile]);
-    assert.strictEqual(child.stderr.toString(), '');
-    assert.match(child.stdout.toString(), /ok 1 - first/);
-    assert.match(child.stdout.toString(), /not ok 2 - second/);
-    assert.match(child.stdout.toString(), /not ok 3 - third/);
-    assert.match(child.stdout.toString(), /not ok 1 - nested/);
-    assert.match(child.stdout.toString(), /# Subtest: top level/);
-    assert.match(child.stdout.toString(), /ok 1 - forth/);
-    assert.match(child.stdout.toString(), /not ok 2 - fifth/);
-    assert.match(child.stdout.toString(), /not ok 2 - top level/);
   });
 });
 
@@ -62,14 +48,4 @@ describe('node:test bail spec', () => {
     assert.doesNotMatch(child.stdout.toString(), /✔ forth/);
     assert.doesNotMatch(child.stdout.toString(), /✖ fifth/);
   });
-
-  it('should exit not exit if bail isnt set', () => {
-    const child = spawnSync(process.execPath, ['--test', '--test-reporter=spec', testFile]);
-    assert.strictEqual(child.stderr.toString(), '');
-    assert.match(child.stdout.toString(), /✔ first/);
-    assert.match(child.stdout.toString(), /✖ second/);
-    assert.match(child.stdout.toString(), /✖ third/);
-    assert.match(child.stdout.toString(), /✔ forth/);
-    assert.match(child.stdout.toString(), /✖ fifth/);
-  });
 });