More instrumentation

Author: manpat

toybox-gfx/src/core.rs

@@ -166,6 +166,7 @@ impl Core {
 		}
 	}
 
+	#[instrument(skip_all, name="gfx Core::set_debugging_enabled")]
 	pub fn set_debugging_enabled(&self, enabled: bool) {
 		unsafe {
 			match enabled {

toybox-gfx/src/lib.rs

@@ -91,15 +91,24 @@ impl System {
 			.context("Error while processing resource requests")
 			.unwrap();
 
-		self.frame_encoder.command_groups.sort_by_key(|cg| cg.stage);
+		{
+			let _span = tracing::info_span!("sort command groups").entered();
+			self.frame_encoder.command_groups.sort_by_key(|cg| cg.stage);
+		}
+
+		// TODO(pat.m): replace clear with just invalidate? may be better to just always render to an fbo and blit
+		// clearing the framebuffer seems useless for any mildly involved rendering
 
 		let clear_color = self.frame_encoder.backbuffer_clear_color;
 		let clear_depth = 1.0; // 1.0 is the default clear depth for opengl
 		let clear_stencil = 0;
 
-		let backbuffer_handle = FramebufferName::backbuffer();
-		self.core.clear_framebuffer_color_buffer(backbuffer_handle, 0, clear_color);
-		self.core.clear_framebuffer_depth_stencil(backbuffer_handle, clear_depth, clear_stencil);
+		{
+			let _span = tracing::info_span!("clear backbuffer").entered();
+			let backbuffer_handle = FramebufferName::backbuffer();
+			self.core.clear_framebuffer_color_buffer(backbuffer_handle, 0, clear_color);
+			self.core.clear_framebuffer_depth_stencil(backbuffer_handle, clear_depth, clear_stencil);
+		}
 
 		let backbuffer_size = self.core.backbuffer_size();
 		self.core.set_viewport(backbuffer_size);

toybox-gfx/src/upload_heap.rs

@@ -137,8 +137,10 @@ impl UploadHeap {
 			.expect("Invalid staged upload id")
 	}
 
+	#[instrument(skip_all, name="UploadHeap::create_end_frame_fence")]
 	pub fn create_end_frame_fence(&mut self, core: &mut Core) {
 		let fence = unsafe {
+			let _span = tracing::info_span!("glFenceSync").entered();
 			core.gl.FenceSync(gl::SYNC_GPU_COMMANDS_COMPLETE, 0)
 		};