build: fix unused function warning and upcoming lifetime warnings

Author: m4b

src/archive/mod.rs

@@ -546,7 +546,7 @@ impl<'a> Archive<'a> {
     /// Get the member named `member` in this archive, if any. If there are
     /// multiple files in the archive with the same name it only returns one
     /// of them.
-    pub fn get(&self, member: &str) -> Option<&Member> {
+    pub fn get(&self, member: &str) -> Option<&Member<'_>> {
         if let Some(idx) = self.members.get(member) {
             Some(&self.member_array[*idx])
         } else {
@@ -555,7 +555,7 @@ impl<'a> Archive<'a> {
     }
 
     /// Get the member at position `index` in this archive, if any.
-    pub fn get_at(&self, index: usize) -> Option<&Member> {
+    pub fn get_at(&self, index: usize) -> Option<&Member<'_>> {
         self.member_array.get(index)
     }
 
@@ -578,7 +578,7 @@ impl<'a> Archive<'a> {
     }
 
     /// Gets a summary of this archive, returning a list of membername, the member, and the list of symbols the member contains
-    pub fn summarize(&self) -> Vec<(&str, &Member, Vec<&'a str>)> {
+    pub fn summarize(&self) -> Vec<(&str, &Member<'_>, Vec<&'a str>)> {
         // build a result array, with indexes matching the member indexes
         let mut result = self
             .member_array

src/lib.rs

@@ -306,7 +306,7 @@ if_everything! {
 
     impl<'a> Object<'a> {
         /// Tries to parse an `Object` from `bytes`
-        pub fn parse(bytes: &[u8]) -> error::Result<Object> {
+        pub fn parse(bytes: &[u8]) -> error::Result<Object<'_>> {
             if let Some(hint_bytes) = take_hint_bytes(bytes) {
                 match peek_bytes(hint_bytes)? {
                     Hint::Elf(_) => Ok(Object::Elf(elf::Elf::parse(bytes)?)),

src/mach/mod.rs

@@ -117,7 +117,7 @@ impl<'a> MachO<'a> {
     /// Return a vector of the relocations in this binary
     pub fn relocations(
         &self,
-    ) -> error::Result<Vec<(usize, segment::RelocationIterator, segment::Section)>> {
+    ) -> error::Result<Vec<(usize, segment::RelocationIterator<'_>, segment::Section)>> {
         debug!("Iterating relocations");
         let mut relocs = Vec::new();
         for (_i, segment) in (&self.segments).into_iter().enumerate() {
@@ -131,15 +131,15 @@ impl<'a> MachO<'a> {
         Ok(relocs)
     }
     /// Return the exported symbols in this binary (if any)
-    pub fn exports(&self) -> error::Result<Vec<exports::Export>> {
+    pub fn exports(&self) -> error::Result<Vec<exports::Export<'_>>> {
         if let Some(ref trie) = self.export_trie {
             trie.exports(self.libs.as_slice())
         } else {
             Ok(vec![])
         }
     }
     /// Return the imported symbols in this binary that dyld knows about (if any)
-    pub fn imports(&self) -> error::Result<Vec<imports::Import>> {
+    pub fn imports(&self) -> error::Result<Vec<imports::Import<'_>>> {
         if let Some(ref interpreter) = self.bind_interpreter {
             interpreter.imports(self.libs.as_slice(), self.segments.as_slice(), self.ctx)
         } else {
@@ -391,7 +391,7 @@ pub fn peek_bytes(bytes: &[u8; 16]) -> error::Result<crate::Hint> {
     }
 }
 
-fn extract_multi_entry(bytes: &[u8]) -> error::Result<SingleArch> {
+fn extract_multi_entry(bytes: &[u8]) -> error::Result<SingleArch<'_>> {
     if let Some(hint_bytes) = take_hint_bytes(bytes) {
         match peek_bytes(hint_bytes)? {
             crate::Hint::Mach(_) => {
@@ -455,7 +455,7 @@ impl<'a> MultiArch<'a> {
         })
     }
     /// Iterate every fat arch header
-    pub fn iter_arches(&self) -> FatArchIterator {
+    pub fn iter_arches(&self) -> FatArchIterator<'_> {
         FatArchIterator {
             index: 0,
             data: self.data,

src/options.rs

@@ -20,11 +20,6 @@ impl ParseMode {
     pub(crate) fn is_permissive(&self) -> bool {
         matches!(self, ParseMode::Permissive)
     }
-
-    /// True if strict.
-    pub(crate) fn is_strict(&self) -> bool {
-        matches!(self, ParseMode::Strict)
-    }
 }
 
 /// Common parsing options.

src/pe/certificate_table.rs

@@ -156,7 +156,7 @@ pub(crate) fn enumerate_certificates(
     bytes: &[u8],
     table_virtual_address: u32,
     table_size: u32,
-) -> Result<CertificateDirectoryTable, error::Error> {
+) -> Result<CertificateDirectoryTable<'_>, error::Error> {
     let table_start_offset = usize::try_from(table_virtual_address).map_err(|_err| {
         error::Error::Malformed("Certificate table RVA do not fit in a usize".to_string())
     })?;

src/pe/relocation.rs

@@ -427,7 +427,7 @@ pub struct RelocationBlock<'a> {
 
 impl RelocationBlock<'_> {
     /// Returns iterator for [`RelocationWord`]
-    pub fn words(&self) -> RelocationWordIterator {
+    pub fn words(&self) -> RelocationWordIterator<'_> {
         RelocationWordIterator {
             bytes: &self.bytes,
             offset: 0,