Skip to content

Commit 7e7577c

Browse files
authored
Merge pull request #139 from lopspower/support_update_publish
[SUPPORT] Update script to publish to Maven Central
2 parents 0ff7713 + f684290 commit 7e7577c

File tree

15 files changed

+141
-92
lines changed

15 files changed

+141
-92
lines changed

.github/CODEOWNERS

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
# Lines starting with '#' are comments.
2+
# Each line is a file pattern followed by one or more owners.
3+
4+
# More details are here: https://help.github.com/articles/about-codeowners/
5+
6+
# The '*' pattern is global owners.
7+
# Not adding in this PR, but I'd like to try adding a global owner set with the entire team.
8+
# One interpretation of their docs is that global owners are added only if not removed
9+
# by a more local rule.
10+
11+
# Order is important. The last matching pattern has the most precedence.
12+
# The folders are ordered as follows:
13+
14+
# In each subsection folders are ordered first by depth, then alphabetically.
15+
# This should make it easy to add new rules without breaking existing ones.
16+
* @lopspower
Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
---
2+
name: Bug report
3+
about: Something is crashing or not working as intended
4+
5+
---
6+
7+
**Please complete the following information:**
8+
- Library Version [e.g. v1.0.0]
9+
- Affected Device(s) [e.g. Samsung Galaxy s10 with Android 9.0]
10+
11+
**Describe the Bug:**
12+
13+
Add a clear description about the problem.
14+
15+
**Expected Behavior:**
16+
17+
A clear description of what you expected to happen.
Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
---
2+
name: Feature request
3+
about: Suggest an idea for this project
4+
5+
---
6+
7+
**Is your feature request related to a problem?**
8+
9+
A clear and concise description of what the problem is.
10+
11+
**Describe the solution you'd like:**
12+
13+
A clear and concise description of what you want to happen.
14+
15+
**Describe alternatives you've considered:**
16+
17+
A clear description of any alternative solutions you've considered.

.github/pull_request_template.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
## Guidelines
2+
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
3+
4+
### Types of changes
5+
What types of changes does your code introduce?
6+
7+
- [ ] Bugfix (non-breaking change which fixes an issue)
8+
- [ ] New feature (non-breaking change which adds functionality)
9+
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ USAGE
2222
To make a circular ImageView add CircularImageView in your layout XML and add CircularImageView library in your project or you can also grab it via Gradle:
2323

2424
```groovy
25-
implementation 'com.mikhaellopez:circularimageview:4.3.0'
25+
implementation 'com.mikhaellopez:circularimageview:4.3.1'
2626
```
2727

2828
XML

build.gradle

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,16 +2,16 @@
22
apply from: 'dependencies.gradle'
33

44
buildscript {
5-
ext.kotlin_version = '1.5.10'
5+
ext.kotlin_version = '1.7.10'
66
repositories {
77
google()
88
mavenCentral()
99
gradlePluginPortal()
1010
}
1111
dependencies {
12-
classpath 'com.android.tools.build:gradle:4.2.1'
12+
classpath 'com.android.tools.build:gradle:7.2.2'
1313
classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
14-
classpath 'com.github.ben-manes:gradle-versions-plugin:0.38.0'
14+
classpath 'com.github.ben-manes:gradle-versions-plugin:0.42.0'
1515
}
1616
}
1717

circularimageview-example/build.gradle

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
1-
apply plugin: 'com.android.application'
2-
apply plugin: 'kotlin-android'
3-
apply plugin: 'com.github.ben-manes.versions'
1+
plugins {
2+
id 'com.android.application'
3+
id 'org.jetbrains.kotlin.android'
4+
id 'com.github.ben-manes.versions'
5+
}
46

57
android {
68
compileSdkVersion androidCompileSdkVersion
@@ -19,8 +21,8 @@ android {
1921
}
2022

2123
dependencies {
22-
//implementation project(':circularimageview')
23-
implementation "com.mikhaellopez:circularimageview:$androidVersionName"
24+
implementation project(':circularimageview')
25+
//implementation "com.mikhaellopez:circularimageview:$androidVersionName"
2426

2527
// KOTLIN
2628
implementation kotlinStdlib

circularimageview-example/src/main/AndroidManifest.xml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,13 @@
33
package="com.mikhaellopez.circularimageviewsample">
44

55
<application
6-
android:allowBackup="false"
76
android:icon="@mipmap/ic_launcher"
87
android:label="@string/app_name"
98
android:theme="@style/Base.Theme"
109
tools:ignore="GoogleAppIndexingWarning">
11-
1210
<activity
1311
android:name=".MainActivity"
14-
android:label="@string/app_name">
12+
android:exported="true">
1513
<intent-filter>
1614
<action android:name="android.intent.action.MAIN" />
1715

circularimageview/build.gradle

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,29 @@
1-
apply plugin: 'com.android.library'
2-
apply plugin: 'kotlin-android'
1+
plugins {
2+
id 'com.android.library'
3+
id 'org.jetbrains.kotlin.android'
4+
}
5+
6+
apply from: rootProject.file('gradle/publish-mavencentral.gradle')
37

48
android {
59
compileSdkVersion androidCompileSdkVersion
610
defaultConfig {
711
minSdkVersion androidMinSdkVersion
812
targetSdkVersion androidTargetSdkVersion
9-
versionCode androidVersionCode
10-
versionName androidVersionName
1113
}
1214
buildTypes {
1315
release {
1416
minifyEnabled false
1517
}
1618
}
19+
publishing {
20+
singleVariant('release') {
21+
withSourcesJar()
22+
}
23+
}
1724
}
1825

1926
dependencies {
2027
implementation kotlinStdlib
2128
implementation androidXAppCompat
2229
}
23-
24-
apply from: rootProject.file('gradle/publish-mavencentral.gradle')

circularimageview/src/main/java/com/mikhaellopez/circularimageview/CircularImageView.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ import kotlin.math.min
1515
import kotlin.math.roundToInt
1616

1717
/**
18-
* Copyright (C) 2020 Mikhael LOPEZ
18+
* Copyright (C) 2022 Mikhael LOPEZ
1919
* Licensed under the Apache License Version 2.0
2020
*/
2121
class CircularImageView @JvmOverloads constructor(

0 commit comments

Comments
 (0)