Skip to content

Commit 1b08d82

Browse files
clsungjmacd
authored andcommitted
Rename GetMeter() to Meter() (#357)
1 parent 5f776db commit 1b08d82

File tree

9 files changed

+11
-11
lines changed

9 files changed

+11
-11
lines changed

api/global/global.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ func SetTraceProvider(tp trace.Provider) {
5555
// MeterProvider returns the registered global meter provider.
5656
// If none is registered then an instance of metric.NoopProvider is returned.
5757
// Use the trace provider to create a named meter. E.g.
58-
// meter := global.MeterProvider().GetMeter("example.com/foo")
58+
// meter := global.MeterProvider().Meter("example.com/foo")
5959
func MeterProvider() metric.Provider {
6060
if gp := globalMeter.Load(); gp != nil {
6161
return gp.(meterProvider).mp

api/global/global_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ func (*testTraceProvider) Tracer(_ string) trace.Tracer {
3636
return &trace.NoopTracer{}
3737
}
3838

39-
func (*testMeterProvider) GetMeter(_ string) metric.Meter {
39+
func (*testMeterProvider) Meter(_ string) metric.Meter {
4040
return &metric.NoopMeter{}
4141
}
4242

api/metric/api.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,9 @@ import (
2323

2424
// Provider supports named Meter instances.
2525
type Provider interface {
26-
// GetMeter gets a named Meter interface. If the name is an
26+
// Meter gets a named Meter interface. If the name is an
2727
// empty string, the provider uses a default name.
28-
GetMeter(name string) Meter
28+
Meter(name string) Meter
2929
}
3030

3131
// LabelSet is an implementation-level interface that represents a

api/metric/noop.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ var _ InstrumentImpl = noopInstrument{}
1818
var _ HandleImpl = noopHandle{}
1919
var _ LabelSet = noopLabelSet{}
2020

21-
func (NoopProvider) GetMeter(name string) Meter {
21+
func (NoopProvider) Meter(name string) Meter {
2222
return NoopMeter{}
2323
}
2424

example/basic/main.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ func main() {
8181
// initialized. See OTEP 0005.
8282

8383
tracer := global.TraceProvider().Tracer("ex.com/basic")
84-
meter := global.MeterProvider().GetMeter("ex.com/basic")
84+
meter := global.MeterProvider().Meter("ex.com/basic")
8585

8686
oneMetric := meter.NewFloat64Gauge("ex.com.one",
8787
metric.WithKeys(fooKey, barKey, lemonsKey),

exporter/metric/dogstatsd/example_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ func ExampleNew() {
6969
key := key.New("key")
7070

7171
// pusher implements the metric.MeterProvider interface:
72-
meter := pusher.GetMeter("example")
72+
meter := pusher.Meter("example")
7373

7474
// Create and update a single counter:
7575
counter := meter.NewInt64Counter("a.counter", metric.WithKeys(key))

sdk/metric/controller/push/push.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -105,9 +105,9 @@ func (c *Controller) SetErrorHandler(errorHandler sdk.ErrorHandler) {
105105
c.sdk.SetErrorHandler(errorHandler)
106106
}
107107

108-
// GetMeter returns a named Meter, satisifying the metric.Provider
108+
// Meter returns a named Meter, satisifying the metric.Provider
109109
// interface.
110-
func (c *Controller) GetMeter(name string) metric.Meter {
110+
func (c *Controller) Meter(name string) metric.Meter {
111111
return c.sdk
112112
}
113113

sdk/metric/controller/push/push_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ func TestPushTicker(t *testing.T) {
171171
fix := newFixture(t)
172172

173173
p := push.New(fix.batcher, fix.exporter, time.Second)
174-
meter := p.GetMeter("name")
174+
meter := p.Meter("name")
175175

176176
mock := mockClock{clock.NewMock()}
177177
p.SetClock(mock)

sdk/metric/example_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ func ExampleNew() {
4545
ctx := context.Background()
4646

4747
key := key.New("key")
48-
meter := pusher.GetMeter("example")
48+
meter := pusher.Meter("example")
4949

5050
counter := meter.NewInt64Counter("a.counter", metric.WithKeys(key))
5151
labels := meter.Labels(key.String("value"))

0 commit comments

Comments
 (0)