fix: Do not send multiple change events when removing multiple nodes that belong to one highlight element

Author: marcbachmann

src/highlight-support.js

@@ -80,10 +80,11 @@ const highlightSupport = {
     const elems = editableHost.querySelectorAll(`[data-word-id="${highlightId}"]`)
     for (const elem of elems) {
       content.unwrap(elem)
-      // in Chrome browsers the unwrap method leaves the host node split into 2 (lastChild !== firstChild)
-      editableHost.normalize()
-      if (dispatcher) dispatcher.notify('change', editableHost)
     }
+
+    // in Chrome browsers the unwrap method leaves the host node split into 2 (lastChild !== firstChild)
+    editableHost.normalize()
+    if (dispatcher) dispatcher.notify('change', editableHost)
   },
 
   hasHighlight (editableHost, highlightId) {

src/plugins/highlighting/text-highlighting.js

@@ -23,10 +23,8 @@ export default class WordHighlighting {
 
   findMatches (text, highlights) {
     if (!text || text === '' || !this.isElement(this.marker)) return
-
-    if (highlights && highlights.length > 0) {
-      return this.searchMatches(text, highlights)
-    }
+    if (!highlights?.length) return
+    return this.searchMatches(text, highlights)
   }
 
   searchMatches (text, highlights) {

src/plugins/highlighting/whitespace-highlighting.js

@@ -23,6 +23,7 @@ const characters = {
 // a paragraph and the highlighting prevents browsers from converting
 // the no-break space back to a normal space when the user keeps typing.
 const specialWhitespaceChars = '\\u2000-\\u200A\\u202F\\u205F\\u3000'
+const specialWhitespaceCharsRegex = new RegExp(`[${specialWhitespaceChars}]`, 'g')
 
 export default class WhitespaceHighlighting {
 
@@ -33,13 +34,7 @@ export default class WhitespaceHighlighting {
   findMatches (text) {
     if (!text) return
 
-    let regex = `[${specialWhitespaceChars}]`
-    regex = new RegExp(regex, 'g')
-
-    const matches = []
-    let match
-    while ((match = regex.exec(text))) matches.push(match)
-
+    const matches = [...text.matchAll(specialWhitespaceCharsRegex)]
     return matches.map((entry) => this.prepareMatch(entry))
   }