fix(tracing): traces were not exposing workload metadata (#14684)

The `linkerd-podinfo` volume wasn't being added to injected pods, thus forbidding traces to expose the pod's metadata.

The cause was that the linkerd-control-plane `values.yaml` file declared the entry `proxy.tracing.enabled` whereas the templates were using `proxy.tracing.enable`.

Author: alpeb

charts/linkerd-control-plane/templates/destination.yaml

@@ -450,6 +450,6 @@ spec:
       - {{- include "partials.proxy.volumes.service-account-token" . | indent 8 | trimPrefix (repeat 7 " ") }}
       {{ end -}}
       - {{- include "partials.proxy.volumes.identity" . | indent 8 | trimPrefix (repeat 7 " ") }}
-      {{ if ((.Values.proxy.tracing).enable) -}}
+      {{ if ((.Values.proxy.tracing).enabled) -}}
       - {{- include "partials.proxy.volumes.podinfo" . | indent 8 | trimPrefix (repeat 7 " ") }}
       {{ end }}

charts/linkerd-control-plane/templates/identity.yaml

@@ -276,7 +276,7 @@ spec:
       - {{- include "partials.proxy.volumes.service-account-token" . | indent 8 | trimPrefix (repeat 7 " ") }}
       {{ end -}}
       - {{- include "partials.proxy.volumes.identity" . | indent 8 | trimPrefix (repeat 7 " ") }}
-      {{- if ((.Values.proxy.tracing).enable) }}
+      {{- if ((.Values.proxy.tracing).enabled) }}
       - {{- include "partials.proxy.volumes.podinfo" . | indent 8 | trimPrefix (repeat 7 " ") }}
       {{- end }}
 {{end -}}

charts/linkerd-control-plane/templates/proxy-injector.yaml

@@ -187,7 +187,7 @@ spec:
       - {{- include "partials.proxy.volumes.service-account-token" . | indent 8 | trimPrefix (repeat 7 " ") }}
       {{ end -}}
       - {{- include "partials.proxy.volumes.identity" . | indent 8 | trimPrefix (repeat 7 " ") }}
-      {{if ((.Values.proxy.tracing).enable) -}}
+      {{if ((.Values.proxy.tracing).enabled) -}}
       - {{- include "partials.proxy.volumes.podinfo" . | indent 8 | trimPrefix (repeat 7 " ") }}
       {{ end }}
 ---

charts/partials/templates/_proxy.tpl

@@ -320,7 +320,7 @@ lifecycle:
 volumeMounts:
 - mountPath: /var/run/linkerd/identity/end-entity
   name: linkerd-identity-end-entity
-{{- if .Values.proxy.tracing | default (dict) | dig "enable" false }}
+{{- if .Values.proxy.tracing | default (dict) | dig "enabled" false }}
 - mountPath: /var/run/linkerd/podinfo
   name: linkerd-podinfo
 {{- end }}

charts/patch/templates/patch.json

@@ -103,7 +103,7 @@ structs.
       }
     }
   },
-  {{- if .Values.proxy.tracing | default (dict) | dig "enable" false }}
+  {{- if .Values.proxy.tracing | default (dict) | dig "enabled" false }}
   {
     "op": "add",
     "path": "{{$prefix}}/spec/volumes/-",