feat(gatewayAPI): Stop installing the gateway API by default (#14523)

We switch the default value of `installGatewayAPI` from true to false.

This has the effect that for Helm installs and upgrades, we will no longer install the gateway API CRDs by default and will instead depend on them already being installed on the cluster.

For Helm upgrades from 2.18, this is a graceful upgrade because 2.18 added the `helm.sh/resource-policy=keep` annotation to these CRDs.  This means that even though this default is changing, upgrading from 2.18 will not cause Helm to delete these CRDs.

This change has no effect on the Linkerd CLI which was already not installing gateway API CRDs by default.

Signed-off-by: Alex Leong <[email protected]>

Author: adleong

charts/linkerd-crds/values.yaml

@@ -1,7 +1,7 @@
 # -- Controls if Linkerd should install the Gateway API CRDs. This value acts
 # as a default and can be overridden by the more specific `enable*Routes`
 # values.
-installGatewayAPI: true
+installGatewayAPI: false
 # -- Controls if Linkerd should install the Gateway API HTTPRoutes and
 # GRPCRoutes CRDs. If unspecified, the value of `installGatewayAPI` is used.
 # enableHttpRoutes: false

cli/cmd/install_test.go

@@ -22,6 +22,16 @@ const (
 	installProxyVersion        = "install-proxy-version"
 	installControlPlaneVersion = "install-control-plane-version"
 	installDebugVersion        = "install-debug-version"
+
+	externalGatewayAPIManifest = `---
+apiVersion: apiextensions.k8s.io/v1
+kind: CustomResourceDefinition
+metadata:
+  name: httproutes.gateway.networking.k8s.io
+spec:
+  versions:
+    - name: v1
+`
 )
 
 func TestRender(t *testing.T) {
@@ -300,16 +310,6 @@ func TestIgnoreCluster(t *testing.T) {
 }
 
 func TestGWApi(t *testing.T) {
-	externalGatewayAPIManifest := `---
-apiVersion: apiextensions.k8s.io/v1
-kind: CustomResourceDefinition
-metadata:
-  name: httproutes.gateway.networking.k8s.io
-spec:
-  versions:
-    - name: v1
-`
-
 	unsupportedGatewayAPIVersionManifest := `---
 apiVersion: apiextensions.k8s.io/v1
 kind: CustomResourceDefinition