fix(itest): retry AssertBalances for 10 seconds

avoids race condition when a balance change is still in-progress

Author: linden

itest/assertions.go

@@ -4,6 +4,7 @@ import (
 	"bytes"
 	"context"
 	"encoding/hex"
+	"errors"
 	"fmt"
 	"reflect"
 	"sort"
@@ -2174,6 +2175,17 @@ func AssertBalances(t *testing.T, client taprpc.TaprootAssetsClient,
 
 	t.Helper()
 
+	err := wait.NoError(func() error {
+		return assertBalances(t, client, balance, opts...)
+	}, 10*time.Second)
+	if err != nil {
+		t.Fatal(err)
+	}
+}
+
+func assertBalances(t *testing.T, client taprpc.TaprootAssetsClient,
+	balance uint64, opts ...BalanceOption) error {
+
 	config := &balanceConfig{}
 	for _, opt := range opts {
 		opt(config)
@@ -2231,7 +2243,9 @@ func AssertBalances(t *testing.T, client taprpc.TaprootAssetsClient,
 			GroupKeyFilter: config.groupKey,
 		},
 	)
-	require.NoError(t, err)
+	if err != nil {
+		return err
+	}
 
 	// Spent assets (burns/tombstones) are never included in the balance,
 	// even if we specifically query for their type. So we skip the balance
@@ -2242,11 +2256,9 @@ func AssertBalances(t *testing.T, client taprpc.TaprootAssetsClient,
 			*config.scriptKeyType != asset.ScriptKeyTombstone)) &&
 		len(config.scriptKey) == 0
 	if checkBalance {
-		require.Equal(
-			t, balance, balanceSum(assetIDBalances, false),
-			"asset balance, wanted %d, got: %v", balance,
-			toJSON(t, assetIDBalances),
-		)
+		if balance != balanceSum(assetIDBalances, false) {
+			return fmt.Errorf("asset balance, wanted %d, got: %v", balance, toJSON(t, assetIDBalances))
+		}
 	}
 
 	// Next, we do the same but grouped by group keys (if requested, since
@@ -2261,18 +2273,17 @@ func AssertBalances(t *testing.T, client taprpc.TaprootAssetsClient,
 				GroupKeyFilter: config.groupKey,
 			},
 		)
-		require.NoError(t, err)
+		if err != nil {
+			return err
+		}
 
 		// Spent assets (burns/tombstones) are never included in the
 		// balance, even if we specifically query for their type. So we
 		// skip the balance check in that case.
 		if checkBalance {
-			require.Equalf(
-				t, config.groupedAssetBalance,
-				balanceSum(assetGroupBalances, true),
-				"grouped balance, wanted %d, got: %v", balance,
-				toJSON(t, assetGroupBalances),
-			)
+			if config.groupedAssetBalance != balanceSum(assetGroupBalances, true) {
+				return fmt.Errorf("grouped balance, wanted %d, got: %v", balance, toJSON(t, assetGroupBalances))
+			}
 		}
 	}
 
@@ -2282,7 +2293,9 @@ func AssertBalances(t *testing.T, client taprpc.TaprootAssetsClient,
 		IncludeLeased: config.includeLeased,
 		ScriptKeyType: rpcTypeQuery,
 	})
-	require.NoError(t, err)
+	if err != nil {
+		return err
+	}
 
 	var (
 		totalBalance uint64
@@ -2320,26 +2333,26 @@ func AssertBalances(t *testing.T, client taprpc.TaprootAssetsClient,
 		totalBalance += a.Amount
 		numUtxos++
 	}
-	require.Equalf(
-		t, balance, totalBalance, "ListAssets balance, wanted %d, "+
-			"got: %v", balance, toJSON(t, assetList),
-	)
+	if balance != totalBalance {
+		return fmt.Errorf("ListAssets balance, wanted %d, got: %v", balance, toJSON(t, assetList))
+	}
 
 	// The number of UTXOs means asset outputs in this case. We check the
 	// BTC-level UTXOs below as well, but that's just to make sure the
 	// output of that RPC lists the same assets.
 	if config.numAssetUtxos > 0 {
-		require.Equal(
-			t, config.numAssetUtxos, numUtxos, "ListAssets num "+
-				"asset utxos",
-		)
+		if config.numAssetUtxos != numUtxos {
+			return errors.New("ListAssets num asset utxos")
+		}
 	}
 
 	utxoList, err := client.ListUtxos(ctxt, &taprpc.ListUtxosRequest{
 		IncludeLeased: config.includeLeased,
 		ScriptKeyType: rpcTypeQuery,
 	})
-	require.NoError(t, err)
+	if err != nil {
+		return err
+	}
 
 	// Make sure the ListUtxos call returns the same number of (asset) UTXOs
 	// as the ListAssets call.
@@ -2386,20 +2399,22 @@ func AssertBalances(t *testing.T, client taprpc.TaprootAssetsClient,
 			numUtxos++
 		}
 	}
-	require.Equal(t, balance, totalBalance, "ListUtxos balance")
+	if balance != totalBalance {
+		return errors.New("ListUtxos balance")
+	}
 
 	if config.numAnchorUtxos > 0 {
-		require.Equal(
-			t, config.numAnchorUtxos, numAnchorUtxos, "num anchor "+
-				"utxos",
-		)
+		if config.numAnchorUtxos != numAnchorUtxos {
+			return errors.New("num anchor utxos")
+		}
 	}
 	if config.numAssetUtxos > 0 {
-		require.Equal(
-			t, config.numAssetUtxos, numUtxos, "ListUtxos num "+
-				"asset utxos",
-		)
+		if config.numAssetUtxos != numUtxos {
+			return errors.New("ListUtxos num asset utxos")
+		}
 	}
+
+	return nil
 }
 
 func assertGroups(t *testing.T, client taprpc.TaprootAssetsClient,