Skip to content

Commit 06206cd

Browse files
authored
address the scala-xml version conflict a different way (#239)
1 parent af5406e commit 06206cd

File tree

5 files changed

+19
-15
lines changed

5 files changed

+19
-15
lines changed

CHANGELOG.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
11
# dbuild release notes
22

3-
### 0.9.19
3+
### 0.9.20
44

5-
- Fix publishing
6-
7-
### 0.9.18
8-
9-
- Force scala-xml dependency to 2.x, for compatibility with sbt 1.8.0
5+
- Support sbt 1.8.0 (by ignoring scala-xml version conflict)
106
- Publish JARs to Maven Central (not Bintray)
117
- Publish tarball to GitHub (not Cloudsmith)
128

9+
### 0.9.19 (withdrawn)
10+
11+
### 0.9.18 (withdrawn)
12+
1313
### 0.9.17
1414

1515
- Use https not http

RELEASING.md

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ You must have rights on Sonatype to publish under `com.typesafe`.
55
You should have a `~/.sbt/0.13/sonatype.sbt` (or similar filename)
66
with the right `credentials += ...`.
77

8-
To create a dbuild release,
8+
To publish a dbuild release,
99

1010
1. Be sure you are running Java 8
1111
2. Run `sbt`
@@ -16,8 +16,15 @@ To create a dbuild release,
1616
Do not try to publish snapshots to Sonatype. Instead, add a custom version
1717
suffix (such as `-RC1`).
1818

19-
If everything goes well, tag the release and push the tag to GitHub.
20-
Also update CHANGELOG.md and publish the website (see below).
19+
If everything goes well, then also:
20+
21+
1. Update CHANGELOG.md
22+
2. Tag the release
23+
3. Push the tag to GitHub,
24+
4. Make a GitHub release from the tag
25+
5. Run `packageZipTarball`
26+
6. Attach the resulting `.tgz` and the `.zip` to the GitHub release
27+
7. Publish the website (see below).
2128

2229
## Publishing (locally)
2330

build.sbt

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,7 @@
11
import Dependencies._
22
import RemoteDepHelper._
33

4-
def MyVersion: String = "0.9.19"
5-
6-
// override to match what Scala 2.12.17 uses
7-
dependencyOverrides in ThisBuild +=
8-
"org.scala-lang.modules" %% "scala-xml" % "2.1.0"
4+
def MyVersion: String = "0.9.20"
95

106
// keep Maven Central happy
117
developers in ThisBuild := List(

build/src/it/scala/com/typesafe/dbuild/build/RewireSpec.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ object RewireSpec extends Specification {
2828
| check-missing: [false, false, false]
2929
| cross-version: standard
3030
| space: test
31-
| sbt-version: "0.13.8"
31+
| sbt-version: "0.13.18"
3232
| extraction-version: "2.11.1"
3333
| projects: [
3434
| {

support/src/main/scala/com/typesafe/dbuild/support/sbt/SbtRunner.scala

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -334,6 +334,7 @@ object SbtRunner {
334334
* The string needed to load the dbuild plugin
335335
*/
336336
val addDBuildPlugin =
337+
"""dependencyOverrides in ThisBuild += "org.scala-lang.modules" %% "scala-xml" % "2.1.0"""" + "\n\n" +
337338
"""addSbtPlugin("com.typesafe.dbuild" % "plugin" % """ + '"' + Defaults.version + "\")\n\n"
338339

339340
/** Perform a state transformation using onLoad() */

0 commit comments

Comments
 (0)