fix!: deep clone incoming routes to prevent side effects (#62)

* fix: deep clone incoming routes to prevent side effects

* feat: added getTools (#61)

* feat: added getTools

* feat!: improve status management (#63)

* refactor: cleanup error messages, add a curly rule to eslint

* refactor: add a curly rule to eslint

* feat: define process type

* feat: get processing messages depending on type and status

* fix: add PENDING state for allowance process after resume

* feat: add TRANSACTION process type

* chore: bump packages

* refactor: remove unnecessary comments

Co-authored-by: Leonardo Cascianelli <[email protected]>
Co-authored-by: Eugene Chybisov <[email protected]>

Author: 3 people

src/Lifi.ts

@@ -44,6 +44,7 @@ import {
 } from './types'
 import { ValidationError } from './utils/errors'
 import { parseBackendError } from './utils/parseError'
+import { deepClone } from './utils/utils'
 
 export default class LIFI {
   private activeRouteDictionary: ActiveRouteDictionary = {}
@@ -233,12 +234,15 @@ export default class LIFI {
     route: Route,
     settings?: ExecutionSettings
   ): Promise<Route> => {
+    const clonedRoute = deepClone<Route>(route) // deep clone to prevent side effects
+
     // check if route is already running
-    if (this.activeRouteDictionary[route.id]) {
-      return route
-    } // TODO: maybe inform user why nothing happens?
+    if (this.activeRouteDictionary[clonedRoute.id]) {
+      // TODO: maybe inform user why nothing happens?
+      return clonedRoute
+    }
 
-    return this.executeSteps(signer, route, settings)
+    return this.executeSteps(signer, clonedRoute, settings)
   }
 
   /**
@@ -254,17 +258,19 @@ export default class LIFI {
     route: Route,
     settings?: ExecutionSettings
   ): Promise<Route> => {
-    const activeRoute = this.activeRouteDictionary[route.id]
+    const clonedRoute = deepClone<Route>(route) // deep clone to prevent side effects
+
+    const activeRoute = this.activeRouteDictionary[clonedRoute.id]
     if (activeRoute) {
       const executionHalted = activeRoute.executors.some(
         (executor) => executor.executionStopped
       )
       if (!executionHalted) {
-        return route
+        return clonedRoute
       }
     }
 
-    return this.executeSteps(signer, route, settings)
+    return this.executeSteps(signer, clonedRoute, settings)
   }
 
   private executeSteps = async (