feat: skip step tx generation if tx data already provided (#100)

* feat: skip step tx generation if tx data already provided

* fix: handle failed normal routes

* fix(ConfigService): config rpc length check

Author: Addminus

src/execution/bridges/bridge.execute.ts

@@ -71,20 +71,21 @@ export class BridgeExecutionManager {
         // check balance
         await balanceCheck(signer, step)
 
-        // create new transaction
-        const personalizedStep = await personalizeStep(signer, step)
-        const updatedStep = await ApiService.getStepTransaction(
-          personalizedStep
-        )
-        step = {
-          ...(await stepComparison(
-            statusManager,
-            personalizedStep,
-            updatedStep,
-            settings.acceptSlippageUpdateHook,
-            this.shouldContinue
-          )),
-          execution: step.execution,
+        if (!step.transactionRequest) {
+          const personalizedStep = await personalizeStep(signer, step)
+          const updatedStep = await ApiService.getStepTransaction(
+            personalizedStep
+          )
+          step = {
+            ...(await stepComparison(
+              statusManager,
+              personalizedStep,
+              updatedStep,
+              settings.acceptSlippageUpdateHook,
+              this.shouldContinue
+            )),
+            execution: step.execution,
+          }
         }
 
         const { transactionRequest } = step

src/execution/exchanges/swap.execute.ts

@@ -68,19 +68,21 @@ export class SwapExecutionManager {
         await balanceCheck(signer, step)
 
         // -> get tx from backend
-        const personalizedStep = await personalizeStep(signer, step)
-        const updatedStep = await ApiService.getStepTransaction(
-          personalizedStep
-        )
-        step = {
-          ...(await stepComparison(
-            statusManager,
-            personalizedStep,
-            updatedStep,
-            settings.acceptSlippageUpdateHook,
-            this.shouldContinue
-          )),
-          execution: step.execution,
+        if (!step.transactionRequest) {
+          const personalizedStep = await personalizeStep(signer, step)
+          const updatedStep = await ApiService.getStepTransaction(
+            personalizedStep
+          )
+          step = {
+            ...(await stepComparison(
+              statusManager,
+              personalizedStep,
+              updatedStep,
+              settings.acceptSlippageUpdateHook,
+              this.shouldContinue
+            )),
+            execution: step.execution,
+          }
         }
 
         const { transactionRequest } = step

src/services/ConfigService.ts

@@ -113,7 +113,7 @@ export default class ConfigService {
       const chainId = chain.id as ChainId
 
       // set RPCs if they were not configured by the user before
-      if (!this.config.rpcs[chainId].length) {
+      if (!this.config.rpcs[chainId]?.length) {
         this.config.rpcs[chainId] = chain.metamask.rpcUrls
       }
 

src/utils/preRestart.ts

@@ -9,6 +9,7 @@ export const handlePreRestart = (route: Route) => {
     if (stepHasFailed) {
       handleErrorType(route, index)
       deleteFailedProcesses(route, index)
+      deleteTransactionData(route, index)
     }
   }
 }
@@ -43,3 +44,7 @@ const deleteFailedProcesses = (route: Route, index: number) => {
     ].execution!.process.filter((process) => process.status !== 'FAILED')
   }
 }
+
+const deleteTransactionData = (route: Route, index: number) => {
+  route.steps[index].transactionRequest = undefined
+}