Added error handling to transport.dial functionality when there is one multiaddr (#133)

Author: michaelfakhri

gulpfile.js

@@ -12,12 +12,17 @@ const multiaddr = require('multiaddr')
 const fs = require('fs')
 const path = require('path')
 
-const sigServer = require('libp2p-webrtc-star/src/signalling-server')
+const sigServer = require('libp2p-webrtc-star/src/signalling')
 
 let swarmA
 let swarmB
 let sigS
 
+const options = {
+  port: 15555,
+  host: '127.0.0.1'
+}
+
 gulp.task('test:browser:before', (done) => {
   function createListenerA (cb) {
     PeerId.createFromJSON(
@@ -70,7 +75,7 @@ gulp.task('test:browser:before', (done) => {
 
   createListenerA(ready)
   createListenerB(ready)
-  sigS = sigServer.start(15555, ready)
+  sigS = sigServer.start(options, ready)
 
   function echo (protocol, conn) {
     pull(conn, conn)

package.json

@@ -45,7 +45,7 @@
     "libp2p-secio": "^0.6.3",
     "libp2p-spdy": "^0.10.0",
     "libp2p-tcp": "^0.9.1",
-    "libp2p-webrtc-star": "^0.6.0",
+    "libp2p-webrtc-star": "^0.7.0",
     "libp2p-websockets": "^0.9.1",
     "pre-commit": "^1.1.3",
     "pull-goodbye": "0.0.1",
@@ -78,4 +78,4 @@
     "Richard Littauer <[email protected]>",
     "Sid Harder <[email protected]>"
   ]
-}
+}

src/transport.js

@@ -41,8 +41,10 @@ module.exports = function (swarm) {
       // b) if multiaddrs.length = 1, return the conn from the
       // transport, otherwise, create a passthrough
       if (multiaddrs.length === 1) {
-        const conn = t.dial(multiaddrs.shift())
-        callback(null, new Connection(conn))
+        const conn = t.dial(multiaddrs.shift(), (err) => {
+          if (err) return callback(err)
+          callback(null, new Connection(conn))
+        })
         return
       }
 

test/browser-01-transport-webrtc-star.js

@@ -75,6 +75,14 @@ describe('transport - webrtc-star', () => {
       )
     })
   })
+  it('dial offline / non-existent node', (done) => {
+    const mhOffline = multiaddr('/libp2p-webrtc-star/ip4/127.0.0.1/tcp/15555/ws/ipfs/ABCD')
+    swarm1.transport.dial('wstar', mhOffline, (err, conn) => {
+      expect(err).to.exist
+      expect(conn).to.not.exist
+      done()
+    })
+  })
 
   it('close', (done) => {
     parallel([