build: Add appropriate compiler defines and flags for SIMD with MSVC (AcademySoftwareFoundation#4266)

This should address the following 2 issues when using MSVC:
- MSVC does not set defines like `__SSE2__` or `__SSE4_2__` etc. we must
do that ourselves
- MSVC uses the `/arch` flag differently than other compilers and it
should be set only once

The ramifications of not having those defines set basically means that
OIIO won't notice any SIMD is possible.

For MSVC the /arch flag only controls which instruction set the compiler
may use when generating code "on its own". For example, the x64 compiler
by default will use SSE2 whenever possible when its generating code but
when using `/arch:AVX` it will produce AVX code as it sees fit. NOTE:
case matters here too! "avx" does not work but "AVX" does.

However, if the source code uses intrinsics, MSVC will happily use those
instead. In fact it's possible to use `avx512` intrinsics without
specifying any /arch flag at all and it will happily generate
corresponding avx512 code. This is much different than say GCC where, in
order to use intrinsics at all, you must specify the corresponding flags
allowing you to do so for the arch in question.

Fixes AcademySoftwareFoundation#4265

## Tests

Existing simd_test.cpp should be sufficient I think. In addition to
those, I've verified the below locally:

Currently: when using `-DUSE_SIMD="sse4.2,avx2"` to build, we get the
wrong `build:simd` flags:
`sse2`

After: using the same flags as above:
`sse2,sse3,ssse3,sse41,sse42,avx,avx2`

---------

Signed-off-by: Jesse Yurkovich <[email protected]>

Author: jessey-git

src/cmake/compiler.cmake

@@ -327,11 +327,29 @@ if (NOT USE_SIMD STREQUAL "")
     if (USE_SIMD STREQUAL "0")
         set (SIMD_COMPILE_FLAGS ${SIMD_COMPILE_FLAGS} "-DOIIO_NO_SIMD=1")
     else ()
+        set(_highest_msvc_arch 0)
         string (REPLACE "," ";" SIMD_FEATURE_LIST ${USE_SIMD})
         foreach (feature ${SIMD_FEATURE_LIST})
             message (VERBOSE "SIMD feature: ${feature}")
             if (MSVC OR CMAKE_COMPILER_IS_INTEL)
-                list (APPEND SIMD_COMPILE_FLAGS "/arch:${feature}")
+                if (feature STREQUAL "sse2")
+                    list (APPEND SIMD_COMPILE_FLAGS "/D__SSE2__")
+                endif ()
+                if (feature STREQUAL "sse4.1")
+                    list (APPEND SIMD_COMPILE_FLAGS "/D__SSE2__" "/D__SSE4_1__")
+                endif ()
+                if (feature STREQUAL "sse4.2")
+                    list (APPEND SIMD_COMPILE_FLAGS "/D__SSE2__" "/D__SSE4_2__")
+                endif ()
+                if (feature STREQUAL "avx" AND _highest_msvc_arch LESS 1)
+                    set(_highest_msvc_arch 1)
+                endif ()
+                if (feature STREQUAL "avx2" AND _highest_msvc_arch LESS 2)
+                    set(_highest_msvc_arch 2)
+                endif ()
+                if (feature STREQUAL "avx512f" AND _highest_msvc_arch LESS 3)
+                    set(_highest_msvc_arch 3)
+                endif ()
             else ()
                 list (APPEND SIMD_COMPILE_FLAGS "-m${feature}")
             endif ()
@@ -343,6 +361,20 @@ if (NOT USE_SIMD STREQUAL "")
                 proj_add_compile_options ("-ffp-contract=off")
             endif ()
         endforeach()
+
+        # Only add a single /arch flag representing the highest level of support.
+        if (MSVC OR CMAKE_COMPILER_IS_INTEL)
+            if (_highest_msvc_arch EQUAL 1)
+                list (APPEND SIMD_COMPILE_FLAGS "/arch:AVX")
+            endif ()
+            if (_highest_msvc_arch EQUAL 2)
+                list (APPEND SIMD_COMPILE_FLAGS "/arch:AVX2")
+            endif ()
+            if (_highest_msvc_arch EQUAL 3)
+                list (APPEND SIMD_COMPILE_FLAGS "/arch:AVX512")
+            endif ()
+        endif ()
+        unset(_highest_msvc_arch)
     endif ()
     proj_add_compile_options (${SIMD_COMPILE_FLAGS})
 endif ()