[Cleanup] Keep flash string when executing internal commands

This did cause a crash when fetching an event from the 2nd heap.

Author: TD-er

src/src/Commands/InternalCommands.cpp

@@ -133,7 +133,7 @@ command_case_data::command_case_data(const char *cmd, struct EventStruct *event,
 
 // Wrapper to reduce generated code by macro
 bool do_command_case_all(command_case_data         & data,
-                         const String              & cmd_test,
+                         const __FlashStringHelper * cmd_test,
                          command_function_fs         pFunc,
                          int                         nrArguments)
 {
@@ -142,7 +142,7 @@ bool do_command_case_all(command_case_data         & data,
 
 
 bool do_command_case_all(command_case_data         & data,
-                         const String              & cmd_test,
+                         const __FlashStringHelper * cmd_test,
                          command_function            pFunc,
                          int                         nrArguments)
 {
@@ -151,7 +151,7 @@ bool do_command_case_all(command_case_data         & data,
 
 // Wrapper to reduce generated code by macro
 bool do_command_case_all_restricted(command_case_data         & data,
-                                    const String              & cmd_test,
+                                    const __FlashStringHelper * cmd_test,
                                     command_function_fs         pFunc,
                                     int                         nrArguments)
 {
@@ -160,7 +160,7 @@ bool do_command_case_all_restricted(command_case_data         & data,
 
 
 bool do_command_case_all_restricted(command_case_data         & data,
-                                    const String              & cmd_test,
+                                    const __FlashStringHelper * cmd_test,
                                     command_function            pFunc,
                                     int                         nrArguments)
 {
@@ -169,9 +169,9 @@ bool do_command_case_all_restricted(command_case_data         & data,
 
 
 bool do_command_case_check(command_case_data         & data,
-                          const String              & cmd_test,
-                          int                         nrArguments,
-                          EventValueSourceGroup::Enum group)
+                           const __FlashStringHelper * cmd_test,
+                           int                         nrArguments,
+                           EventValueSourceGroup::Enum group)
 {
   // The data struct is re-used on each attempt to process an internal command.
   // Re-initialize the only two members that may have been altered by a previous call.
@@ -202,7 +202,7 @@ bool do_command_case_check(command_case_data         & data,
 }
 
 bool do_command_case(command_case_data         & data,
-                     const String              & cmd_test,
+                     const __FlashStringHelper * cmd_test,
                      command_function_fs         pFunc,
                      int                         nrArguments,
                      EventValueSourceGroup::Enum group)
@@ -217,7 +217,7 @@ bool do_command_case(command_case_data         & data,
 
 
 bool do_command_case(command_case_data         & data,
-                     const String              & cmd_test,
+                     const __FlashStringHelper * cmd_test,
                      command_function            pFunc,
                      int                         nrArguments,
                      EventValueSourceGroup::Enum group)

src/src/Commands/InternalCommands.h

@@ -32,8 +32,8 @@ struct command_case_data {
 
 };
 
-bool do_command_case(command_case_data& data, const String& cmd_test, command_function_fs pFunc, int nrArguments, EventValueSourceGroup::Enum group);
-bool do_command_case(command_case_data& data, const String& cmd_test, command_function pFunc, int nrArguments, EventValueSourceGroup::Enum group);
+bool do_command_case(command_case_data& data, const __FlashStringHelper * cmd_test, command_function_fs pFunc, int nrArguments, EventValueSourceGroup::Enum group);
+bool do_command_case(command_case_data& data, const __FlashStringHelper * cmd_test, command_function pFunc, int nrArguments, EventValueSourceGroup::Enum group);
 
 
 /*********************************************************************************************\