fix(world): fix static array arguments in system libraries (#3661)

Co-authored-by: V <[email protected]>

Author: dk1a

.changeset/lovely-knives-leave.md

@@ -0,0 +1,5 @@
+---
+"@latticexyz/world": patch
+---
+
+Fix static array arguments in system libraries.

packages/world/ts/node/render-solidity/renderSystemLibrary.ts

@@ -7,6 +7,7 @@ import {
 } from "@latticexyz/common/codegen";
 import { RenderSystemLibraryOptions } from "./types";
 import { ContractInterfaceError } from "@latticexyz/common/codegen";
+import { stringToHex } from "viem";
 
 export function renderSystemLibrary(options: RenderSystemLibraryOptions) {
   const {
@@ -289,6 +290,8 @@ function functionInterfaceName(contractFunction: ContractInterfaceFunction) {
   const paramTypes = parameters
     .map((param) => param.split(" ")[0])
     .map((type) => type.replace("[]", "Array"))
+    // Static arrays may contain multiple disallowed symbols, for name uniqueness toHex is easier than escaping
+    .map((type) => type.replace(/\[.+\]/, (match) => stringToHex(match)))
     .join("_");
   return `_${name}${paramTypes.length === 0 ? "" : `_${paramTypes}`}`;
 }

test/system-libraries/src/codegen/world/IASystem.sol

@@ -6,6 +6,7 @@ import { Value } from "./codegen/tables/Value.sol";
 import { PositionValue } from "./codegen/tables/PositionValue.sol";
 import { AddressValue } from "./codegen/tables/AddressValue.sol";
 import { ASystemThing, Position } from "./ASystemTypes.sol";
+import { THREE } from "./ASystemConstants.sol";
 
 contract ASystem is System {
   function setValue(ASystemThing memory value) external {
@@ -43,4 +44,24 @@ contract ASystem is System {
     AddressValue.set(addr);
     return addr;
   }
+
+  function setValuesStaticArray(uint256[1] memory values) external {
+    Value.set(values[0]);
+  }
+
+  function setValuesStaticArray(uint256[2] memory values) external {
+    Value.set(values[1]);
+  }
+
+  function setValuesStaticArray(uint256[THREE] memory values) external {
+    Value.set(values[2]);
+  }
+
+  /*
+  // TODO: support this case
+  // (see flattenTypeName in contractToInterface.ts)
+  function setValuesStaticArray(uint256[1 - 0 * 2 + THREE] memory values) external {
+    Value.set(values[3]);
+  }
+  */
 }

test/system-libraries/src/namespaces/a/ASystem.sol

@@ -0,0 +1,4 @@
+// SPDX-License-Identifier: MIT
+pragma solidity >=0.8.28;
+
+uint256 constant THREE = 3;

test/system-libraries/src/namespaces/a/ASystemConstants.sol

@@ -53,6 +53,13 @@ contract LibrariesTest is MudTest {
     assertEq(PositionValue.getX(), 4);
     assertEq(PositionValue.getY(), 5);
     assertEq(PositionValue.getZ(), 6);
+
+    aSystem.setValuesStaticArray([uint256(1)]);
+    assertEq(Value.get(), 1);
+    aSystem.setValuesStaticArray([uint256(1), 2]);
+    assertEq(Value.get(), 2);
+    aSystem.setValuesStaticArray([uint256(1), 2, 3]);
+    assertEq(Value.get(), 3);
   }
 
   function testCanCallSystemFromOtherSystem() public {