Refactor: create tag via console if not exists

Signed-off-by: Nathanael Esayeas <[email protected]>

Author: ghostwriter

bin/console.php

@@ -24,6 +24,7 @@
 use Laminas\AutomaticReleases\Git\CreateTagViaConsole;
 use Laminas\AutomaticReleases\Git\FetchAndSetCurrentUserByReplacingCurrentOriginRemote;
 use Laminas\AutomaticReleases\Git\GetMergeTargetCandidateBranchesFromRemoteBranches;
+use Laminas\AutomaticReleases\Git\HasTagViaConsole;
 use Laminas\AutomaticReleases\Git\PushViaConsole;
 use Laminas\AutomaticReleases\Github\Api\GraphQL\Query\GetMilestoneFirst100IssuesAndPullRequests;
 use Laminas\AutomaticReleases\Github\Api\GraphQL\RunGraphQLQuery;
@@ -127,7 +128,7 @@ static function (int $errorCode, string $message = '', string $file = '', int $l
             $getMilestone,
             $commitChangelog,
             $createReleaseText,
-            new CreateTagViaConsole(),
+            new CreateTagViaConsole(new HasTagViaConsole()),
             $push,
             $createRelease,
         ),

src/Git/CreateTagViaConsole.php

@@ -6,25 +6,39 @@
 
 use Laminas\AutomaticReleases\Git\Value\BranchName;
 use Laminas\AutomaticReleases\Gpg\SecretKeyId;
-use Psl\Env;
-use Psl\File;
-use Psl\Filesystem;
-use Psl\Shell;
+
+use function Psl\Env\temp_dir;
+use function Psl\File\write;
+use function Psl\Filesystem\create_temporary_file;
+use function Psl\Shell\execute;
 
 final class CreateTagViaConsole implements CreateTag
 {
+    public function __construct(private HasTag $hasTag)
+    {
+    }
+
     public function __invoke(
         string $repositoryDirectory,
         BranchName $sourceBranch,
         string $tagName,
         string $changelog,
         SecretKeyId $keyId,
     ): void {
-        $tagFileName = Filesystem\create_temporary_file(Env\temp_dir(), 'created_tag');
+        if (($this->hasTag)($repositoryDirectory, $tagName) === true) {
+            return;
+        }
+
+        $tagFileName = create_temporary_file(temp_dir(), 'created_tag');
+
+        write($tagFileName, $changelog);
 
-        File\write($tagFileName, $changelog);
+        execute('git', ['checkout', $sourceBranch->name()], $repositoryDirectory);
 
-        Shell\execute('git', ['checkout', $sourceBranch->name()], $repositoryDirectory);
-        Shell\execute('git', ['tag', $tagName, '-F', $tagFileName, '--cleanup=whitespace', '--local-user=' . $keyId->id()], $repositoryDirectory);
+        execute(
+            'git',
+            ['tag', $tagName, '-F', $tagFileName, '--cleanup=whitespace', '--local-user=' . $keyId->id()],
+            $repositoryDirectory,
+        );
     }
 }

test/unit/Git/CreateTagViaConsoleTest.php

@@ -5,6 +5,8 @@
 namespace Laminas\AutomaticReleases\Test\Unit\Git;
 
 use Laminas\AutomaticReleases\Git\CreateTagViaConsole;
+use Laminas\AutomaticReleases\Git\HasTag;
+use Laminas\AutomaticReleases\Git\HasTagViaConsole;
 use Laminas\AutomaticReleases\Git\Value\BranchName;
 use Laminas\AutomaticReleases\Gpg\ImportGpgKeyFromStringViaTemporaryFile;
 use Laminas\AutomaticReleases\Gpg\SecretKeyId;
@@ -47,18 +49,20 @@ protected function setUp(): void
     public function testCreatesSignedTag(): void
     {
         $sourceUri = $this->createMock(UriInterface::class);
+        $sourceUri->method('__toString')->willReturn($this->repository);
 
-        $sourceUri->method('__toString')
-            ->willReturn($this->repository);
+        $hasTag = $this->createMock(HasTag::class);
+        $hasTag->method('__invoke')
+            ->with($this->repository, 'name-of-the-tag')
+            ->willReturn(false);
 
-        (new CreateTagViaConsole())
-            ->__invoke(
-                $this->repository,
-                BranchName::fromName('tag-branch'),
-                'name-of-the-tag',
-                'changelog text for the tag',
-                $this->key,
-            );
+        (new CreateTagViaConsole($hasTag))(
+            $this->repository,
+            BranchName::fromName('tag-branch'),
+            'name-of-the-tag',
+            'changelog text for the tag',
+            $this->key,
+        );
 
         Shell\execute('git', ['tag', '-v', 'name-of-the-tag'], $this->repository);
 
@@ -69,4 +73,36 @@ public function testCreatesSignedTag(): void
         self::assertStringContainsString('a commit', $fetchedTag);
         self::assertStringContainsString('-----BEGIN PGP SIGNATURE-----', $fetchedTag);
     }
+
+    public function testSkipsIfTagAlreadyExists(): void
+    {
+        $sourceUri = $this->createMock(UriInterface::class);
+        $sourceUri->method('__toString')->willReturn($this->repository);
+
+        $hasTag = new HasTagViaConsole();
+
+        (new CreateTagViaConsole($hasTag))(
+            $this->repository,
+            BranchName::fromName('tag-branch'),
+            'name-of-the-tag',
+            'changelog text for the tag',
+            $this->key,
+        );
+
+        Shell\execute('git', ['tag', '-v', 'name-of-the-tag'], $this->repository);
+        $fetchedTag = Shell\execute('git', ['show', 'name-of-the-tag'], $this->repository);
+
+        self::assertStringContainsString('tag name-of-the-tag', $fetchedTag);
+        self::assertStringContainsString('changelog text for the tag', $fetchedTag);
+        self::assertStringContainsString('a commit', $fetchedTag);
+        self::assertStringContainsString('-----BEGIN PGP SIGNATURE-----', $fetchedTag);
+
+        (new CreateTagViaConsole($hasTag))(
+            $this->repository,
+            BranchName::fromName('tag-branch'),
+            'name-of-the-tag',
+            'changelog text for the tag',
+            $this->key,
+        );
+    }
 }