Fix byte division.

The previous fix didn't work so I added tests for the new
rounding-divide function I introduced.

Author: alysbrooks

src/kaocha/plugin/gc_profiling.clj

@@ -25,6 +25,13 @@
   (- (.totalMemory (Runtime/getRuntime))
      (.freeMemory (Runtime/getRuntime))))
 
+(defn rounding-divide 
+  "Divide two numbers and round them.
+  
+  Unlike quot, this rounds rather than truncates."
+  [m n]
+  (Math/round (double (/ m  n))))
+
 (defn start [testable]
   (assoc testable ::start (get-memory)))
 
@@ -93,7 +100,7 @@
               (doseq [{:keys [::delta :kaocha.testable/id] :as test} largest
                       :let [n (count (remove ::testable/skip (:kaocha.result/tests test)))]]
                 (cond 
-                  (> n 0) (let [avg (long (Math/round (/ delta  n)))]
+                  (> n 0) (let [avg (rounding-divide delta n)]
                             (println (format "%s%s    \n%s\033[1m%s\033[0m average (%s / %d tests)" indentation-str 
                                              id (str indentation-str indentation-str)
                                              (convert-bytes avg) (convert-bytes delta) n)))

test/unit/kaocha/plugin/gc_profiling_test.clj

@@ -40,6 +40,36 @@
     (is
       (= "-11B" (gc/convert-bytes -11)))))
 
+(deftest rounding-divide
+  (testing "Yielding whole numbers."
+    (is 
+      (= 2 (gc/rounding-divide 4 2)))
+    (is 
+      (= 2 (gc/rounding-divide 4.0 2)))
+    (is 
+      (= 2 (gc/rounding-divide 4 2.0)))
+    (is 
+      (= 2 (gc/rounding-divide 4.0 2.0))))
+  (testing "Yielding rational numbers as decimals."
+    (is 
+      (= 3 (gc/rounding-divide 5 2)))
+    (is 
+      (= 3 (gc/rounding-divide 5 2.0)))
+    (is 
+      (= 3 (gc/rounding-divide 5.0 2)))
+    (is
+      (= 3 (gc/rounding-divide 5.0 2.0))))
+  (testing "Yielding rational numbers as decimals."
+    (is 
+      (= -2 (gc/rounding-divide -5 2)))
+    (is 
+      (= -2 (gc/rounding-divide -5 2.0)))
+    (is 
+      (= -2 (gc/rounding-divide -5.0 2)))
+    (is
+      (= -2 (gc/rounding-divide -5.0 2.0)))))
+
+
 (deftest gc-profiling-test
   (plugin/with-plugins plugin-chain
     (is