fix(geometry): Fix subtle bug in remove_colinear_vertices

Author: chriswmackey

ladybug_geometry/geometry2d/polygon.py

@@ -624,7 +624,7 @@ def remove_colinear_vertices(self, tolerance):
         for i, _v in enumerate(self.vertices):
             _v2, _v1 = self[i - 2 - skip], self[i - 1]
             _a = _v2.determinant(_v1) + _v1.determinant(_v) + _v.determinant(_v2)
-            b_dist = _v.distance_to_point(_v2)
+            b_dist = max(_v.distance_to_point(_v2), _v.distance_to_point(_v1))
             b_dist = tolerance if b_dist < tolerance else b_dist
             tri_tol = (b_dist * tolerance) / 2  # area of triangle with tolerance height
             if abs(_a) >= tri_tol:  # triangle area > tolerance; not colinear
@@ -641,7 +641,7 @@ def remove_colinear_vertices(self, tolerance):
                 'There must be at least 3 vertices for a Polygon2D.'
             _v2, _v1, _v = self[-2 - skip], self[-1], self[first_skip]
             _a = _v2.determinant(_v1) + _v1.determinant(_v) + _v.determinant(_v2)
-            b_dist = _v.distance_to_point(_v2)
+            b_dist = max(_v.distance_to_point(_v2), _v.distance_to_point(_v1))
             b_dist = tolerance if b_dist < tolerance else b_dist
             tri_tol = (b_dist * tolerance) / 2  # area of triangle with tolerance height
             if abs(_a) >= tri_tol:  # triangle area > area tolerance; not colinear

ladybug_geometry/geometry2d/polyline.py

@@ -155,7 +155,7 @@ def remove_colinear_vertices(self, tolerance):
         for i, _v in enumerate(self.vertices[1:-1]):
             _v2, _v1 = self[i - skip], self[i + 2]
             _a = _v2.determinant(_v) + _v.determinant(_v1) + _v1.determinant(_v2)
-            b_dist = _v1.distance_to_point(_v2)
+            b_dist = max(_v2.distance_to_point(_v1), _v2.distance_to_point(_v))
             b_dist = tolerance if b_dist < tolerance else b_dist
             tri_tol = (b_dist * tolerance) / 2  # area of triangle with tolerance height
             if abs(_a) >= tri_tol:  # triangle area > tolerance; not colinear

ladybug_geometry/geometry3d/face.py

@@ -3037,7 +3037,7 @@ def _remove_colinear(self, pts_3d, pts_2d, tolerance):
         for i, _v in enumerate(pts_2d):
             _v2, _v1 = pts_2d[i - 2 - skip], pts_2d[i - 1]
             _a = _v2.determinant(_v1) + _v1.determinant(_v) + _v.determinant(_v2)
-            b_dist = _v.distance_to_point(_v2)
+            b_dist = max(_v.distance_to_point(_v2), _v.distance_to_point(_v1))
             b_dist = tolerance if b_dist < tolerance else b_dist
             tri_tol = (b_dist * tolerance) / 2  # area of triangle with tolerance height
             if abs(_a) >= tri_tol:  # triangle area > area tolerance; not colinear
@@ -3054,7 +3054,7 @@ def _remove_colinear(self, pts_3d, pts_2d, tolerance):
                 'There must be at least 3 vertices for a Face3D.'
             _v2, _v1, _v = pts_2d[-2 - skip], pts_2d[-1], pts_2d[first_skip]
             _a = _v2.determinant(_v1) + _v1.determinant(_v) + _v.determinant(_v2)
-            b_dist = _v.distance_to_point(_v2)
+            b_dist = max(_v.distance_to_point(_v2), _v.distance_to_point(_v1))
             b_dist = tolerance if b_dist < tolerance else b_dist
             tri_tol = (b_dist * tolerance) / 2  # area of triangle with tolerance height
             if abs(_a) >= tri_tol:  # triangle area > area tolerance; not colinear

ladybug_geometry/geometry3d/polyline.py

@@ -143,7 +143,7 @@ def remove_colinear_vertices(self, tolerance):
         for i, _v in enumerate(self.vertices[1:-1]):
             _v2, _v1 = self[i - skip], self[i + 2]
             _a = (_v2 - _v).cross(_v1 - _v).magnitude
-            b_dist = _v1.distance_to_point(_v2)
+            b_dist = max(_v2.distance_to_point(_v1), _v2.distance_to_point(_v))
             b_dist = tolerance if b_dist < tolerance else b_dist
             tri_tol = (b_dist * tolerance) / 2  # area of triangle with tolerance height
             if abs(_a) >= tri_tol:  # triangle area > tolerance; not colinear