address comments

Author: Liujingfang1

pkg/inventory/policy.go

@@ -32,7 +32,6 @@ const (
 	// The prune operation can go through when
 	// - The owning-inventory annotation in the live object match with that
 	//   in the package.
-	// - The live object doesn't have the owning-inventory annotation.
 	InventoryPolicyMustMatch InventoryPolicy = iota
 
 	// AdoptIfNoInventory: This policy enforces that resources being applied
@@ -60,7 +59,7 @@ const (
 	// live object has an unmatched owning-inventory annotation.
 	//
 	// The prune operation can go through when
-	// - The owning-inventory annotation in the live object match with that
+	// - The owning-inventory annotation in the live object match or doesn't match with that
 	//   in the package.
 	// - The live object doesn't have the owning-inventory annotation.
 	AdoptAll
@@ -122,11 +121,11 @@ func CanPrune(inv InventoryInfo, obj *unstructured.Unstructured, policy Inventor
 	matchStatus := inventoryIDMatch(inv, obj)
 	switch matchStatus {
 	case Empty:
-		return true
+		return policy == AdoptIfNoInventory || policy == AdoptAll
 	case Match:
 		return true
 	case NoMatch:
-		return false
+		return policy == AdoptAll
 	}
 	return false
 }

pkg/inventory/policy_test.go

@@ -197,7 +197,7 @@ func TestCanPrune(t *testing.T) {
 			obj:      testObjectWithAnnotation("", ""),
 			inv:      &fakeInventoryInfo{id: "random-id"},
 			policy:   InventoryPolicyMustMatch,
-			canPrune: true,
+			canPrune: false,
 		},
 		{
 			name:     "matched with InventoryPolicyMustMatch",
@@ -239,7 +239,7 @@ func TestCanPrune(t *testing.T) {
 			obj:      testObjectWithAnnotation(owningInventoryKey, "unmatched"),
 			inv:      &fakeInventoryInfo{id: "random-id"},
 			policy:   AdoptAll,
-			canPrune: false,
+			canPrune: true,
 		},
 	}
 	for _, tc := range testcases {