Merge pull request #511 from Abirdcfly/master

k8s-ci-robot · web-flow · commit 9c1359e68b93 · 2023-08-11T10:53:27.000-07:00
fix: metric frontend_write_duration_seconds has wrong value
diff --git a/pkg/server/server.go b/pkg/server/server.go
@@ -106,8 +106,7 @@ const (
 )
 
 func (c *ProxyClientConnection) send(pkt *client.Packet) error {
-	start := time.Now()
-	defer metrics.Metrics.ObserveFrontendWriteLatency(time.Since(start))
+	defer func(start time.Time) { metrics.Metrics.ObserveFrontendWriteLatency(time.Since(start)) }(time.Now())
 	if c.Mode == "grpc" {
 		return c.frontend.Send(pkt)
 	}

Original file line number	Diff line number	Diff line change
`@@ -106,8 +106,7 @@ const (`
`106`	`106`	`)`
`107`	`107`
`108`	`108`	`func (c ProxyClientConnection) send(pkt client.Packet) error {`
`109`		`- start := time.Now()`
`110`		`- defer metrics.Metrics.ObserveFrontendWriteLatency(time.Since(start))`
	`109`	`+ defer func(start time.Time) { metrics.Metrics.ObserveFrontendWriteLatency(time.Since(start)) }(time.Now())`
`111`	`110`	`if c.Mode == "grpc" {`
`112`	`111`	`return c.frontend.Send(pkt)`
`113`	`112`	`}`