Skip to content

Commit 8fc4058

Browse files
authored
fix(chart): remove operator namespace default for job namespaces value (#1989)
Signed-off-by: t3mi <[email protected]>
1 parent bf2ecce commit 8fc4058

File tree

5 files changed

+7
-7
lines changed

5 files changed

+7
-7
lines changed

charts/spark-operator-chart/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
apiVersion: v2
22
name: spark-operator
33
description: A Helm chart for Spark on Kubernetes operator
4-
version: 1.2.12
4+
version: 1.2.13
55
appVersion: v1beta2-1.4.4-3.5.0
66
keywords:
77
- spark

charts/spark-operator-chart/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# spark-operator
22

3-
![Version: 1.2.12](https://img.shields.io/badge/Version-1.2.12-informational?style=flat-square) ![AppVersion: v1beta2-1.4.4-3.5.0](https://img.shields.io/badge/AppVersion-v1beta2--1.4.4--3.5.0-informational?style=flat-square)
3+
![Version: 1.2.13](https://img.shields.io/badge/Version-1.2.13-informational?style=flat-square) ![AppVersion: v1beta2-1.4.4-3.5.0](https://img.shields.io/badge/AppVersion-v1beta2--1.4.4--3.5.0-informational?style=flat-square)
44

55
A Helm chart for Spark on Kubernetes operator
66

@@ -126,7 +126,7 @@ See [helm uninstall](https://helm.sh/docs/helm/helm_uninstall) for command docum
126126
| serviceAccounts.sparkoperator.create | bool | `true` | Create a service account for the operator |
127127
| serviceAccounts.sparkoperator.name | string | `""` | Optional name for the operator service account |
128128
| sidecars | list | `[]` | Sidecar containers |
129-
| sparkJobNamespaces | list | `[]` | List of namespaces where to run spark jobs, operator namespace is included only when list of namespaces is empty |
129+
| sparkJobNamespaces | list | `[]` | List of namespaces where to run spark jobs |
130130
| tolerations | list | `[]` | List of node taints to tolerate |
131131
| uiService.enable | bool | `true` | Enable UI service creation for Spark application |
132132
| volumeMounts | list | `[]` | |

charts/spark-operator-chart/templates/deployment.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44
# In the post-install hook, the token corresponding to the operator service account
55
# is used to authenticate with the Kubernetes API server to install the secret bundle.
6-
{{- $jobNamespaces := .Values.sparkJobNamespaces | default (list .Release.Namespace) }}
6+
{{- $jobNamespaces := .Values.sparkJobNamespaces | default list }}
77
---
88
apiVersion: apps/v1
99
kind: Deployment
@@ -66,7 +66,7 @@ spec:
6666
args:
6767
- -v={{ .Values.logLevel }}
6868
- -logtostderr
69-
{{- if le (len $jobNamespaces) 1 }}
69+
{{- if eq (len $jobNamespaces) 1 }}
7070
- -namespace={{ index $jobNamespaces 0 }}
7171
{{- end }}
7272
- -enable-ui-service={{ .Values.uiService.enable}}

charts/spark-operator-chart/templates/spark-rbac.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{{- if or .Values.rbac.create .Values.rbac.createRole }}
2-
{{- $jobNamespaces := .Values.sparkJobNamespaces | default (list .Release.Namespace) }}
2+
{{- $jobNamespaces := .Values.sparkJobNamespaces | default list }}
33
{{- range $jobNamespace := $jobNamespaces }}
44
---
55
apiVersion: rbac.authorization.k8s.io/v1

charts/spark-operator-chart/values.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ serviceAccounts:
5252
# -- Optional annotations for the operator service account
5353
annotations: {}
5454

55-
# -- List of namespaces where to run spark jobs, operator namespace is included only when list of namespaces is empty
55+
# -- List of namespaces where to run spark jobs
5656
sparkJobNamespaces: []
5757
# - ns1
5858

0 commit comments

Comments
 (0)