Skip to content

Commit b6f8d22

Browse files
authored
Rename edit command to copy (#3094)
1 parent c6bc428 commit b6f8d22

File tree

2 files changed

+11
-10
lines changed

2 files changed

+11
-10
lines changed

commands/rpkgcmd.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@ import (
2121

2222
"github.com/GoogleContainerTools/kpt/internal/cmdrpkgapprove"
2323
"github.com/GoogleContainerTools/kpt/internal/cmdrpkgclone"
24+
"github.com/GoogleContainerTools/kpt/internal/cmdrpkgcopy"
2425
"github.com/GoogleContainerTools/kpt/internal/cmdrpkgdel"
25-
"github.com/GoogleContainerTools/kpt/internal/cmdrpkgedit"
2626
"github.com/GoogleContainerTools/kpt/internal/cmdrpkgget"
2727
"github.com/GoogleContainerTools/kpt/internal/cmdrpkginit"
2828
"github.com/GoogleContainerTools/kpt/internal/cmdrpkgpropose"
@@ -76,7 +76,7 @@ func NewRpkgCommand(ctx context.Context, version string) *cobra.Command {
7676
cmdrpkgapprove.NewCommand(ctx, kubeflags),
7777
cmdrpkgreject.NewCommand(ctx, kubeflags),
7878
cmdrpkgdel.NewCommand(ctx, kubeflags),
79-
cmdrpkgedit.NewCommand(ctx, kubeflags),
79+
cmdrpkgcopy.NewCommand(ctx, kubeflags),
8080
)
8181

8282
return repo

internal/cmdrpkgedit/command.go renamed to internal/cmdrpkgcopy/command.go

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
// See the License for the specific language governing permissions and
1313
// limitations under the License.
1414

15-
package cmdrpkgedit
15+
package cmdrpkgcopy
1616

1717
import (
1818
"context"
@@ -28,9 +28,9 @@ import (
2828
)
2929

3030
const (
31-
command = "cmdrpkgedit"
31+
command = "cmdrpkgcopy"
3232
longMsg = `
33-
kpt alpha rpkg edit SOURCE_PACKAGE NAME
33+
kpt alpha rpkg copy SOURCE_PACKAGE NAME
3434
3535
Creates a new copy of a source package in the target repository.
3636
@@ -63,10 +63,11 @@ func newRunner(ctx context.Context, rcg *genericclioptions.ConfigFlags) *runner
6363
cfg: rcg,
6464
}
6565
c := &cobra.Command{
66-
Use: "edit SOURCE_PACKAGE NAME",
66+
Use: "copy SOURCE_PACKAGE NAME",
67+
Aliases: []string{"edit"},
6768
Short: "Creates a copy of a source package in the target repository.",
6869
Long: longMsg,
69-
Example: "kpt alpha rpkg edit upstream-package-name target-package-name --repository target-repository --revision v1",
70+
Example: "kpt alpha rpkg copy upstream-package-name target-package-name --repository target-repository --revision v1",
7071
PreRunE: r.preRunE,
7172
RunE: r.runE,
7273
Hidden: porch.HidePorchCommands,
@@ -85,7 +86,7 @@ type runner struct {
8586
client client.Client
8687
Command *cobra.Command
8788

88-
edit porchapi.PackageEditTaskSpec
89+
copy porchapi.PackageEditTaskSpec
8990

9091
repository string // Target repository
9192
revision string // Target package revision
@@ -111,7 +112,7 @@ func (r *runner) preRunE(cmd *cobra.Command, args []string) error {
111112
source := args[0]
112113
target := args[1]
113114

114-
r.edit.Source = &porchapi.PackageRevisionRef{
115+
r.copy.Source = &porchapi.PackageRevisionRef{
115116
Name: source,
116117
}
117118

@@ -138,7 +139,7 @@ func (r *runner) runE(cmd *cobra.Command, args []string) error {
138139
Tasks: []porchapi.Task{
139140
{
140141
Type: porchapi.TaskTypeEdit,
141-
Edit: &r.edit,
142+
Edit: &r.copy,
142143
},
143144
},
144145
},

0 commit comments

Comments
 (0)