Skip to content

Commit 9a9131f

Browse files
author
Mengqi Yu
authored
fix e2e test in local mode (#3143)
1 parent 92fbb86 commit 9a9131f

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed

porch/pkg/engine/builtinruntime.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,9 @@ import (
2727
"github.com/GoogleContainerTools/kpt/porch/pkg/kpt"
2828
)
2929

30+
// When updating the version for the builtin functions, please also update the image version
31+
// in test TestBuiltinFunctionEvaluator in porch/test/e2e/e2e_test.go, if the versions mismatch
32+
// the e2e test will fail in local deployment mode.
3033
var (
3134
applyReplacementsImageAliases = []string{
3235
"gcr.io/kpt-fn/apply-replacements:v0.1.1",

porch/test/e2e/e2e_test.go

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -834,7 +834,8 @@ func (t *PorchSuite) TestBuiltinFunctionEvaluator(ctx context.Context) {
834834
{
835835
Type: "eval",
836836
Eval: &porchapi.FunctionEvalTaskSpec{
837-
Image: "gcr.io/kpt-fn/starlark:v0.4.2",
837+
//
838+
Image: "gcr.io/kpt-fn/starlark:v0.4.3",
838839
ConfigMap: map[string]string{
839840
"source": `for resource in ctx.resource_list["items"]:
840841
resource["metadata"]["annotations"]["foo"] = "bar"`,
@@ -959,6 +960,10 @@ for resource in ctx.resource_list["items"]:
959960
}
960961

961962
func (t *PorchSuite) TestPodFunctionEvaluatorWithDistrolessImage(ctx context.Context) {
963+
if t.local {
964+
t.Skipf("Skipping due to not having pod evalutor in local mode")
965+
}
966+
962967
t.registerMainGitRepositoryF(ctx, "git-fn-distroless")
963968

964969
// Create Package Revision

0 commit comments

Comments
 (0)